Skip to content

gnrc_ipv6_nib: actually timeout a default router#8071

Merged
cgundogan merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_ipv6_nib/fix/rtr-timeout
Nov 17, 2017
Merged

gnrc_ipv6_nib: actually timeout a default router#8071
cgundogan merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_ipv6_nib/fix/rtr-timeout

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 17, 2017

While the GNRC_IPV6_NIB_RTR_TIMEOUT is properly handled, it is actually
never fired. Moreover, the router lifetime is set, but never read.

This removes the router lifetime and switches it out for an evtimer
to does the GNRC_IPV6_NIB_RTR_TIMEOUT event.

While the GNRC_IPV6_NIB_RTR_TIMEOUT is properly handled, it is actually
never fired. Moreover, the router lifetime is set, but never read.

This removes the router lifetime and switches it out for an evtimer
to does the GNRC_IPV6_NIB_RTR_TIMEOUT event.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) GNRC Area: network Area: Networking labels Nov 17, 2017
@miri64 miri64 requested a review from cgundogan November 17, 2017 10:44
Copy link
Copy Markdown
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane! ACK

@cgundogan cgundogan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 17, 2017
@cgundogan cgundogan merged commit abe721f into RIOT-OS:gnrc_netif2_integration/master Nov 17, 2017
@miri64 miri64 deleted the gnrc_ipv6_nib/fix/rtr-timeout branch November 17, 2017 11:03
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants