boards/nucleo: share board.h and board.c by haukepetersen · Pull Request #8065 · RIOT-OS/RIOT

haukepetersen · 2017-11-16T17:21:13Z

~~Based on #8058~~ and cuts out part from #8044

As #8044 is getting out of hand, I think it makes sense to split its aspects into separate PRs. This PR does two things:

make a distinction between common/nucleo and common/nucleo64
make all nucleo boards use shared board.h (by type, one for 32, 64, and 144) and a single shared board.c file

Especially the diff of the last commit (175 additions and 2,293 deletions) seems to be a good start :-)

haukepetersen · 2017-11-30T12:12:20Z

rebased, as #8058 was merged.

vincent-d · 2017-11-30T13:00:42Z

Looks good. I have no time to test it today.

Let's give Murdock a try.

smlng · 2017-12-04T08:28:57Z

please also consider #8189 to keep the doc consistent

haukepetersen · 2017-12-04T08:39:33Z

yes, will adapt the doc

smlng · 2017-12-04T08:41:15Z

yes, will adapt the doc

great! Merging #8189 (before this one), would be nice, too - but it needs approval, first 😉

haukepetersen · 2017-12-04T08:48:46Z

will take a look later today

aabadie · 2017-12-18T16:10:15Z

#8189 is merged, can you rebase @haukepetersen ?

haukepetersen · 2018-01-05T11:25:12Z

sorry for the delay: adapted doxygen groups to the changes in #8189 and rebased.

aabadie · 2018-01-05T14:28:44Z

Looks good for me. I'll test on a subset of boards next week.

aabadie

Tested examples/default on a set of nucleo boards: works for nucleo32-l031, nucleo-l152 (when disabling LSE), nucleo-l476, nucleo32-l432, nucleo-f072, nucleo144-f207, nucleo32-f303, nucleo-f446 and nucleo144-f746. I don't have a nucleo-f103 (I lent it) but except this one I tested all nucleo cpu families.

Otherwise, I think I found an issue with doxygen grouping and there's the problem with the AUTO_INIT_LED0 that doesn't apply to nucleo144 boards.

aabadie · 2018-01-15T07:53:22Z

boards/common/nucleo/board.c

+ */
+
+/**
+ * @ingroup     boards_nucleo


If I get it right, it should be boards_common_nucleo

aabadie · 2018-01-15T07:56:52Z

boards/common/nucleo/board.c

+
+    /* initialization of on-board LEDs
+     * NOTE: LED0 must be explicitly enabled as it is also used for SPI_DEV(0) */
+#ifdef AUTO_INIT_LED0


This is only the case for nucleo32 and nucleo64 boards. nucleo144 boards are using different pins for SPI and on-board leds.

aabadie · 2018-01-17T11:39:46Z

Please rebase @haukepetersen

haukepetersen · 2018-01-22T11:24:20Z

rebased and added a fix to always initialize LED0 for Nucleo144 boards.

kaspar030 · 2018-01-22T11:24:46Z

boards/common/nucleo/Makefile.include

+
+# select OpenOCD configuration depending on CPU type
+ifeq (,$(OPENOCD_CONFIG))
+  ifeq ($(CPU),stm32f0)


how about
export OPENOCD_CONFIG := $(RIOTBOARD)/common/nucleo/dist/$(patsubst stm32%,openocd-%.cfg,$(CPU)).

And please add an error case, e.g., err out on if $(,$(filter stm32%,$(CPU))

sounds good. Ok if I do it in a separate PR?

done #8391: 9bbd78d

haukepetersen · 2018-01-24T09:22:19Z

grr, have to rebase again -> because of #8405 this time. Can we please get this merged soon, so this will not happen every time? Also things like #8405 are so much easier to do with this PR merged...

haukepetersen · 2018-01-24T09:31:48Z

adapted to #8405

haukepetersen · 2018-01-24T09:32:51Z

@kaspar030 @aabadie: you think we could this in soonish? I get tired of maintaining this PR and all of your previous comments should be addressed :-)

aabadie

Un-retested ACK. The change of auto init led0 should be ok with nucleo-144.

Thanks for rebasing again btw

kaspar030 · 2018-01-24T14:18:05Z

Tested on nucleo-f401. ACK.

haukepetersen · 2018-01-24T14:58:26Z

finally, thanks a lot for reviewing and testing!

haukepetersen added Area: boards Area: Board ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first labels Nov 16, 2017

haukepetersen assigned aabadie Nov 16, 2017

This was referenced Nov 17, 2017

discussion on architecture: supporting MCU and BOARD features in which files #8066

Closed

boards/nucleo: concept for vastly improving code re-usage [WIP] #8044

Closed

haukepetersen force-pushed the opt_boards_nucleo-board.hc branch from 3a836fb to 5a3233c Compare November 30, 2017 12:11

haukepetersen removed the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 30, 2017

haukepetersen force-pushed the opt_boards_nucleo-board.hc branch from 5a3233c to 74bd1b5 Compare November 30, 2017 12:18

vincent-d added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 30, 2017

haukepetersen force-pushed the opt_boards_nucleo-board.hc branch from 74bd1b5 to bee0f13 Compare January 5, 2018 11:24

aabadie requested changes Jan 15, 2018

View reviewed changes

haukepetersen force-pushed the opt_boards_nucleo-board.hc branch from bee0f13 to 99c847f Compare January 22, 2018 11:18

kaspar030 requested changes Jan 22, 2018

View reviewed changes

haukepetersen mentioned this pull request Jan 22, 2018

boards/nucleo: optimize openocd file selection #8391

Closed

haukepetersen added 3 commits January 24, 2018 10:23

boards/nucleo: factored out nucleo64 common

b4f497f

boards/nucleo: use shard board.h and board.c files

c6c0b75

boards/nucleo/doc: assign boards to nucleo groups

7ca0bcf

haukepetersen added 3 commits January 24, 2018 10:24

boards/nucleo144: always (auto-) initialize LED0

fa0f4be

boards/nucleo: fixed doxygen group in board.c

18268ea

boards/nucleo*: use unified doxygen brief desc

4f1ce14

haukepetersen force-pushed the opt_boards_nucleo-board.hc branch from e8cc937 to 4f1ce14 Compare January 24, 2018 09:31

aabadie approved these changes Jan 24, 2018

View reviewed changes

kaspar030 approved these changes Jan 24, 2018

View reviewed changes

kaspar030 merged commit 2b73449 into RIOT-OS:master Jan 24, 2018

haukepetersen deleted the opt_boards_nucleo-board.hc branch January 24, 2018 14:58

This was referenced Jan 25, 2018

boards/nucleo*: fix doxygen grouping #8432

Merged

boards: rename nucleo144-f207 to nucleo-f207zg #8435

Merged

boards/nucleo-l452: initial support #8441

Merged

Conversation

haukepetersen commented Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haukepetersen commented Nov 30, 2017

Uh oh!

vincent-d commented Nov 30, 2017

Uh oh!

smlng commented Dec 4, 2017

Uh oh!

haukepetersen commented Dec 4, 2017

Uh oh!

smlng commented Dec 4, 2017

Uh oh!

haukepetersen commented Dec 4, 2017

Uh oh!

aabadie commented Dec 18, 2017

Uh oh!

haukepetersen commented Jan 5, 2018

Uh oh!

aabadie commented Jan 5, 2018

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

aabadie Jan 15, 2018

Choose a reason for hiding this comment

Uh oh!

aabadie Jan 15, 2018

Choose a reason for hiding this comment

Uh oh!

aabadie commented Jan 17, 2018

Uh oh!

haukepetersen commented Jan 22, 2018

Uh oh!

kaspar030 Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

haukepetersen Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

haukepetersen Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

kaspar030 Jan 24, 2018

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Jan 24, 2018

Uh oh!

haukepetersen commented Jan 24, 2018

Uh oh!

haukepetersen commented Jan 24, 2018

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

kaspar030 commented Jan 24, 2018

Uh oh!

haukepetersen commented Jan 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

haukepetersen commented Nov 16, 2017 •

edited

Loading