gnrc: remove legacy GNRC code#8064
gnrc: remove legacy GNRC code#8064bergzand merged 2 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
Conversation
miri64
added
Type: cleanup
miri64
force-pushed
the
gnrc/cleanup/rm-legacy
branch
7 times, most recently
from
c52823b to
69b72f8
Compare
miri64
changed the title
|
I think this PR is big enough without the rename. Will provide the rename in a follow-up. |
|
This is not WIP anymore, when Murdock passes. |
|
Murdock likes it! :-) |
| # implicitly pulled in by gnrc_ipv6_netif (which is a dependency of gnrc_ipv6) | ||
| # already. | ||
| ifneq (,$(filter gnrc_icmpv6_echo,$(USEMODULE))) | ||
| ifneq (,$(filter xtimer,$(USEMODULE))) |
There was a problem hiding this comment.
Why the explicit check for xtimer?
There was a problem hiding this comment.
See the removed comment above. gnrc_netif2 doesn't have this dependency. gnrc_ipv6_nib has it, but less obvious and I also think that dependencies should be as explicit as possible.
There was a problem hiding this comment.
So only the shell command requires the xtimer (and not the icmpv6 echo code itself). From an end user perspective, I would be suprised not to get the shell command when enabling the gnrc_icmpv6_echo module. I don't think the explicit check here is bad, I'm mostly doubting whether instead of an ifneq check, just pulling in xtimer as an additional dependency makes more sense.
As an example, on this branch, the gnrc_networking example includes xtimer due to the inclusing of RPL, if say a user were to remove the RPL module, he suddenly loses the icmpv6 command for no immediatly visible reason.
There was a problem hiding this comment.
So only the shell command requires the xtimer (and not the icmpv6 echo code itself). From an end user perspective, I would be suprised not to get the shell command when enabling the gnrc_icmpv6_echo module. I don't think the explicit check here is bad, I'm mostly doubting whether instead of an ifneq check, just pulling in xtimer as an additional dependency makes more sense.
It would be very inconsistent to pull it in here, also: other shell commands do it like I do here as well (and this PR is not about changing that).
As an example, on this branch, the gnrc_networking example includes xtimer due to the inclusing of RPL, if say a user were to remove the RPL module, he suddenly loses the icmpv6 command for no immediatly visible reason.
Then still gnrc_ipv6_nib would (indirectly) include xtimer. It is very unlikely that a user using gnrc_ipv6 would not use xtimer as well. Anyone who does I assume knows what they are doing ;-).
There was a problem hiding this comment.
It would be very inconsistent to pull it in here, also: other shell commands do it like I do here as well (and this PR is not about changing that).
Okay, I can live with this :)
Anyone who does I assume knows what they are doing ;-).
Lets hope so :)
miri64
force-pushed
the
gnrc/cleanup/rm-legacy
branch
from
69b72f8 to
636ef2a
Compare
|
Rebased to current #7925 |
|
Go ahead and merge if you want! :-) |
3 participants
This removes (the old)
gnrc_netif,gnrc_ipv6_netif,gnrc_sixlowpan_netif, and the oldgnrc_ndp(with all its submodules). It is still WIP, but I don't want to mark it as such, since I want to let Murdock test it iteratively in case I missed something.