Skip to content

examples: gnrc_tftp: add bluepill board to insufficient memory list#8063

Merged
bergzand merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:examples/fix/bluepill-mem
Nov 16, 2017
Merged

examples: gnrc_tftp: add bluepill board to insufficient memory list#8063
bergzand merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:examples/fix/bluepill-mem

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 16, 2017

The NIB makes this application (for now) to big for this board. So put it into the list of boards with insufficient memory for now.

@miri64 miri64 added GNRC Area: network Area: Networking labels Nov 16, 2017
@miri64 miri64 requested review from bergzand and smlng November 16, 2017 16:08
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 16, 2017
Copy link
Copy Markdown
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad ACK

@bergzand bergzand merged commit f54d882 into RIOT-OS:gnrc_netif2_integration/master Nov 16, 2017
@miri64 miri64 deleted the examples/fix/bluepill-mem branch November 17, 2017 05:20
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Nov 17, 2017

Well actually I have another problem... This board has a bootloader which can be overwritten if you flash it using a SWD adaptor (like ST-Link), in which case you can use the whole memory. However, if you decide to use the internal bootloader the size of the ROM is decreased by 8K, which don't fit in the examples found by Murdock on #7799.

This PR got merged before I thought about it, I wanted to ask you to include the examples found by Murdock...

I guess I need to open a new one...

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 17, 2017

This PR got merged before I thought about it, I wanted to ask you to include the examples found by Murdock...

  1. Adding a board to the list of boards with insufficient memory doesn't mean Murdock doesn't build (i.e. compile) it anymore, it just isn't linked, so I'm not sure what you mean by that.
  2. The plan is to optimize GNRC after gnrc_netif2: gnrc_ipv6_nib: full integration into GNRC #7925 was merged (my personal goal is to be able to run on chronos, but maybe that is to high set ^^) and then this list will shrink again anyway.

This PR got merged before I thought about it, I wanted to ask you to include the examples found by Murdock...

I guess I need to open a new one...

  1. This PR is against gnrc_netif2_integration/master, not master ;-).

@bergzand
Copy link
Copy Markdown
Member

This PR got merged before I thought about it,

Sorry if I was too trigger-happy with this PR. As @miri64 said, the code is still build, but not linked, so I didn't see too much harm in this

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 17, 2017

@bergzand no worries. @kYc0o and I just discussed this online. Actually his comment was supposed to say, that due to the mentioned bootloader, the available space is actually smaller than the linker script suggests (which ignores the bootloader entirely). So adding it to BOARD_INSUFFICIENT_MEMORY was definitely the right call (for now).

@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants