Skip to content

gnrc_netif2: make more complexer functions not inline#8049

Merged
bergzand merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_netif2/opt/uninline
Nov 16, 2017
Merged

gnrc_netif2: make more complexer functions not inline#8049
bergzand merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_netif2/opt/uninline

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 16, 2017

With this optimization I get about

  • 150-200 B less on Cortex-M platforms
  • 200 B less on MSP430 platforms
  • 300-350 B less on AVR, ARM-7, and MIPS platforms

when I merge this one into #7479.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation GNRC Area: network Area: Networking labels Nov 16, 2017
@miri64 miri64 requested a review from bergzand November 16, 2017 08:47
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 16, 2017
@bergzand
Copy link
Copy Markdown
Member

Murdock is unhappy here, I can reproduce the build failure from the ccn-lite-relay example.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 16, 2017

Fixed.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 16, 2017

Nope... wrong branch >.< I need ☕

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 16, 2017

I can reproduce the build failure from the ccn-lite-relay example.

Maybe putting the functions in the MODULE_GNRC_IPV6 #ifdef wasn't the best idea ;-)

@bergzand
Copy link
Copy Markdown
Member

Thanks for the build size numbers, that was the first question I wanted to ask.

Murdock is happy, I'm good with this. Please squash.

@miri64 miri64 force-pushed the gnrc_netif2/opt/uninline branch from d71410c to 62a1f08 Compare November 16, 2017 13:44
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 16, 2017

Squashed

Copy link
Copy Markdown
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green, ACK

@bergzand bergzand merged commit 911f197 into RIOT-OS:gnrc_netif2_integration/master Nov 16, 2017
@miri64 miri64 deleted the gnrc_netif2/opt/uninline branch November 16, 2017 14:00
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants