Skip to content

pkg/libcoap: adapt Makefile to fix compile error#8030

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
smlng:pkg/libcoap/fix_compiler_error
Nov 24, 2017
Merged

pkg/libcoap: adapt Makefile to fix compile error#8030
miri64 merged 1 commit intoRIOT-OS:masterfrom
smlng:pkg/libcoap/fix_compiler_error

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Nov 14, 2017

fixes compile error in pkg/libcoap revealed in #8029

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: pkg Area: External package ports labels Nov 14, 2017
@smlng smlng requested a review from kaspar030 November 14, 2017 10:36
@smlng smlng mentioned this pull request Nov 14, 2017
Merged
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Nov 14, 2017

Murdock output for reference

@smlng smlng requested review from cgundogan and miri64 November 14, 2017 10:44
@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 14, 2017
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Nov 14, 2017

In libcoap, the debug.c file already has patches, so I would prefer fixing it to include string.h rather than disabling the warning.

@smlng smlng force-pushed the pkg/libcoap/fix_compiler_error branch 2 times, most recently from 096815d to 5f87da8 Compare November 14, 2017 15:41
@smlng smlng changed the title pkg/libcoap: set -Wno-implicit-function-declaration pkg/libcoap: adapt config.h to fix compile error Nov 14, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Nov 14, 2017

@cladmi I fixed the patch as you suggested

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Nov 15, 2017

Instead of disabling strlen, you can enable it in the package makefile with:

-+CFLAGS += -DWITH_POSIX
++CFLAGS += -DWITH_POSIX -D_GNU_SOURCE=1

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Nov 15, 2017

@cladmi wasn't aware of that, thanks for the pointer I'll give it a try!

@smlng smlng force-pushed the pkg/libcoap/fix_compiler_error branch from 5f87da8 to 5939cd4 Compare November 17, 2017 17:45
@smlng smlng changed the title pkg/libcoap: adapt config.h to fix compile error pkg/libcoap: adapt Makefile to fix compile error Nov 17, 2017
miri64
miri64 approved these changes Nov 24, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit 6df7d02 into RIOT-OS:master Nov 24, 2017
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
@smlng smlng deleted the pkg/libcoap/fix_compiler_error branch February 6, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees

@miri64 miri64

@cgundogan cgundogan

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.01

Development

Successfully merging this pull request may close these issues.

5 participants

@smlng @cladmi @miri64 @cgundogan @aabadie