Skip to content

tests/lwmac: cleaned up used modules and Makefile#8022

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_tests_lwmacmodules
Nov 27, 2017
Merged

tests/lwmac: cleaned up used modules and Makefile#8022
miri64 merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_tests_lwmacmodules

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

The test application was to large parts a 'dont-ask' copy from the default example. This PR removes some of the left-overs and unrealted modules: ltc4150, SAUL, etc. The RTC does not need to be initialized, this is done by auto-init (or soon by periph_init..). Also there is no need for differentiating platforms with and without radio, as the test is only whitelisted for a single board...

@haukepetersen haukepetersen added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tests Area: tests and testing framework labels Nov 13, 2017
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 13, 2017

Technically this is under the GNRC merge embargo, but it doesn't cause a conflict with #7925 (yet). Since this test uses the initialization abstraction of GNRC quite well I don't expect it to be the case anytime soon, but let's be safe and merge it not yet.

@zhuoshuguo
Copy link
Copy Markdown
Contributor

Thanks for cleaning up the mess I introduced!

@haukepetersen
Copy link
Copy Markdown
Contributor Author

no problem :-)

@haukepetersen
Copy link
Copy Markdown
Contributor Author

@miri64 how about you just put a change request to this PR so it is not merged by accident?!

Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@miri64 miri64 added the GNRC label Nov 24, 2017
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Let's Murdock give a final run before merging this

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 27, 2017
@miri64 miri64 merged commit 31924e9 into RIOT-OS:master Nov 27, 2017
@haukepetersen haukepetersen deleted the fix_tests_lwmacmodules branch November 29, 2017 08:42
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
@miri64 miri64 added Platform: MSP Platform: This PR/issue effects MSP-based platforms Area: network Area: Networking labels Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MSP Platform: This PR/issue effects MSP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants