Skip to content

nrf51: fix returns and error codes in periph/i2c#8018

Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
smlng:nrf51/fix_i2c
Nov 16, 2017
Merged

nrf51: fix returns and error codes in periph/i2c#8018
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
smlng:nrf51/fix_i2c

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Nov 13, 2017

as requested in #7995 this fixes returns and error codes of periph/i2c to match API specs.

@smlng smlng added Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 13, 2017
@miri64 miri64 removed their request for review November 15, 2017 17:37
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 15, 2017

Since I don't really know anything about the innards of periph_i2c I leave the review to @haukepetersen.

Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Tested with a yunjia-nrf51822 + SRF02 (i2c sensor)

@PeterKietzmann PeterKietzmann merged commit ea5d61f into RIOT-OS:master Nov 16, 2017
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
@smlng smlng deleted the nrf51/fix_i2c branch February 6, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants