Skip to content

cpu, atmega_common: fix returns and error codes in periph/i2c#8017

Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
smlng:atmega_common/fix_i2c
Nov 16, 2017
Merged

cpu, atmega_common: fix returns and error codes in periph/i2c#8017
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
smlng:atmega_common/fix_i2c

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Nov 13, 2017

factored out from #7995, as requested.

Mainly corrects/replaces asserts by checks using if to return proper error codes as specified by API.

@smlng smlng requested a review from haukepetersen November 13, 2017 12:28
@smlng smlng added Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Nov 13, 2017
@smlng smlng requested a review from miri64 November 13, 2017 12:28
@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 13, 2017
@smlng smlng mentioned this pull request Nov 13, 2017
Merged
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 13, 2017

Can you add the fix for the nrf51 as well? Either here in a separate commit or in a separate PR.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Nov 13, 2017

@miri64 see #8018

@smlng smlng requested a review from PeterKietzmann November 14, 2017 17:44
@miri64 miri64 removed their request for review November 15, 2017 17:36
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 15, 2017

Since I don't really know anything about the innards of periph_i2c I leave the review to @haukepetersen or @PeterKietzmann.

PeterKietzmann
PeterKietzmann approved these changes Nov 16, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Quickly tested with a mega2560+srf02 (i2c sensor)

@PeterKietzmann PeterKietzmann merged commit e60a750 into RIOT-OS:master Nov 16, 2017
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
@smlng smlng deleted the atmega_common/fix_i2c branch February 6, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.01

Development

Successfully merging this pull request may close these issues.

4 participants

@smlng @miri64 @PeterKietzmann @aabadie