gnrc_mac: fix non-obvious recursive include#8016
Merged
kaspar030 merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom Nov 13, 2017
Merged
Conversation
miri64
added
Type: bug
This was referenced Nov 13, 2017
kaspar030
added
the
CI: ready for build
kaspar030
approved these changes
Nov 13, 2017
Contributor
kaspar030
left a comment
kaspar030
left a comment
There was a problem hiding this comment.
I guess if it still builds, it works. ACK.
Member
Author
|
@kaspar030 just to warn you: Murdock will fail. You have to look at the results of the unittests. |
Member
Author
|
(The whole |
Contributor
Unittests all built correctly. Go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net/gnrc/mac/types.his already included bynet/gnrc/netif2.h. Likewise,net/gnrc/mac/types.his includingnet/gnrc.hwhich in turn includes alsonet/gnrc/netif2.h. This recursive inclusion causes some confusion to the compiler who than in some instances can't find thegnrc_mactypes innet/gnrc/netif2.h. This PR takes care of that by removing one redundant include ofnet/gnrc/mac/types.h.