cpu, sam3: fix periph/dac poweron#8013
Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom Nov 13, 2017
Merged
Conversation
smlng
added
Area: drivers
smlng
added
the
CI: ready for build
haukepetersen
requested changes
Nov 13, 2017
| PMC->PMC_PCER1 = (1 << (ID_DACC - 32)); | ||
| DACC->DACC_CHER = PMC_BIT; | ||
| DACC->DACC_CHER = (1 << line); | ||
| PMC->PMC_PCER1 = PMC_BIT; |
Contributor
There was a problem hiding this comment.
This seems incorrect to me: at least the order is broken now -> the module clock gate bit needs to be enabled before the actual module enable bit...
smlng
force-pushed
the
cpu/sam3/fix_periph_dac
branch
from
3f48267 to
eb8c55d
Compare
Member
Author
|
@haukepetersen fixed order |
Contributor
|
all green -> go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
factored out from #7995, as requested.
fixes poweron function for DAC of SAM3 cpu.