Skip to content

examples/gnrc_br: revert removal of pca1000x#7986

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:revert_pca_gnrcborderrouterblacklist
Nov 9, 2017
Merged

examples/gnrc_br: revert removal of pca1000x#7986
miri64 merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:revert_pca_gnrcborderrouterblacklist

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

revert the removal of the pca1000x boards from this Makefile to prevent merge conflicts for the gnrc_netif2 integration.

@miri64 promised to remove these entries again once gnrc_netif2 is merged...

@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 9, 2017

Is this an actual revert commit? Not sure it works otherwise.

@miri64 miri64 added GNRC Area: network Area: Networking labels Nov 9, 2017
@haukepetersen
Copy link
Copy Markdown
Contributor Author

nope, just a commit that reverts the change...

Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then let's just try it

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 9, 2017
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 9, 2017

Added this PR to the gnrc_ipv6_nib / gnrc_netif2 Integration project as reminder to re-apply the change after #7925 is merged

@haukepetersen
Copy link
Copy Markdown
Contributor Author

alright.

@miri64 miri64 merged commit f3a94c7 into RIOT-OS:master Nov 9, 2017
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 9, 2017

(Worked btw 👍)

@haukepetersen
Copy link
Copy Markdown
Contributor Author

awesome. The rest is up to you :-)

And sorry for the inconvenience, did not think about the GNRC merge blockade when touching the examples...

@haukepetersen haukepetersen deleted the revert_pca_gnrcborderrouterblacklist branch November 10, 2017 09:06
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 17, 2017
As in RIOT-OS#7986 this application (obviously) causes a conflict in RIOT-OS#7925
since RIOT-OS#7979. This PR fixes that.
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants