boards: removed support for pca1000[0|5]#7979
Merged
kaspar030 merged 4 commits intoRIOT-OS:masterfrom Nov 9, 2017
Merged
Conversation
haukepetersen
added
Area: boards
Member
|
👍 |
jnohlgard
approved these changes
Nov 9, 2017
Member
jnohlgard
left a comment
jnohlgard
left a comment
There was a problem hiding this comment.
Looks OK, this should be good to go if Murdock doesn't complain about anything missing.
Contributor
Author
|
I think I forgot to look for blacklistings throughout the tests, will do that now. |
Contributor
Author
|
ok, good thing we talked about it :-) Removed all occurences of pca1000x from the examples and applications. |
Contributor
|
&go. |
miri64
reviewed
Nov 9, 2017
| nucleo-f334 nucleo-l053 nucleo-l073 opencm904 pca10000 \ | ||
| pca10005 spark-core stm32f0discovery telosb wsn430-v1_3b \ | ||
| nucleo-f334 nucleo-l053 nucleo-l073 opencm904 \ | ||
| spark-core stm32f0discovery telosb wsn430-v1_3b \ |
Member
There was a problem hiding this comment.
This line cause a merge conflict in the gnrc_netif2 integration (see #7925). Is there a way to revert this for now?
Contributor
There was a problem hiding this comment.
Isn't that only relevant when you actually merge?
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 17, 2017
As in RIOT-OS#7986 this application (obviously) causes a conflict in RIOT-OS#7925 since RIOT-OS#7979. This PR fixes that.
This was referenced Nov 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both boards were early development kits by Nordic and are to my knowledge discontinued, as both have (way more affordable) successors:
pca10000->nrf51donglepca10005->nrf51dkAlso we don't have a
pca10000available to us anymore (went up in smoke quite a while ago), and thepca10005is not trivial to flash (needs external jlink adapter...), so we have not tested it in probably 2 or more years. Further it seems that there are not many of these boards around in general, so I don't think someone will even notice that we drop their support...Will provide entries to the
LOSTANDFOUND.mdin a separate PR.EDIT: see #7980