drivers/mrf24j40: add peripheral requirements to Makefile dependencies#7977
Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom Nov 9, 2017
Merged
drivers/mrf24j40: add peripheral requirements to Makefile dependencies#7977bergzand merged 1 commit intoRIOT-OS:masterfrom
bergzand merged 1 commit intoRIOT-OS:masterfrom
Conversation
PeterKietzmann
added
the
CI: ready for build
Contributor
|
A small description for this PR would have been useful... |
Contributor
|
I think in this case it speaks for itself. |
Contributor
|
I agree, but I guess we can be a bit more consistent on the way we open PRs. I believe a small description at least, for this kind of PRs, should be mandatory. For other PRs a more elaborated comment is necessary, as @kaspar030 has pointed out already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.