Skip to content

examples: tests: port applications to gnrc_netif2#7966

Merged
miri64 merged 11 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_netif2/fix/7424-follow-up
Nov 13, 2017
Merged

examples: tests: port applications to gnrc_netif2#7966
miri64 merged 11 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_netif2/fix/7424-follow-up

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 8, 2017 •
edited
Loading

I've missed some applications in #7424. This takes care of most of them. I also know of gnrc_ipv6_ext but when I fix the compile issue the test itself fails. I have to look into that deeper and then will provide a fix for that as well

This PR is part of the network layer remodelling effort:
PR dependencies

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) GNRC Area: network Area: Networking labels Nov 8, 2017
@miri64 miri64 requested review from bergzand and smlng November 8, 2017 18:05
This was referenced Nov 8, 2017
Merged
Merged
@smlng
Copy link
Copy Markdown
Member

smlng commented Nov 8, 2017

I do get lets of linker errors for missing symbols of netif (old version1) functions, is that to be expected? For instance when compiling examples/nanocoap_server. Maybe you need to remove USEMODULE += auto_init_gnrc_netif from the Makefiles as well?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 8, 2017

I do get lets of linker errors for missing symbols of netif (old version1) functions, is that to be expected? For instance when compiling examples/nanocoap_server. Maybe you need to remove USEMODULE += auto_init_gnrc_netif from the Makefiles as well?

Nope, they are all NDP related (look at the objects that cause those linker errors). They should be fixed in #7456.

@miri64 miri64 force-pushed the gnrc_netif2/fix/7424-follow-up branch from a3664c9 to 57ac108 Compare November 11, 2017 18:38
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Nov 11, 2017
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 11, 2017

All except the errors involving the devices added in #7414, #7419, #7462, and #7898 should now be fixed. If not I will provide a further follow-up later.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 13, 2017

Ok. I searched for all the "failed:" in Murdock's log now. Only remaining fails are in tests, that try to link in cc110x code (fixed in #7414) and nordic_softdevice_ble code (fixed in #7419), the test applications for xbee (fixed in #7898) and slip (fixed in #7462), and the unittests due to a bug in gnrc_mac (fixed in #8016). Everything else is now accounted for in this PR => Ready for review.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 13, 2017

@bergzand can you have a look at this as well, please?

@bergzand
Copy link
Copy Markdown
Member

bergzand commented Nov 13, 2017

@bergzand can you have a look at this as well, please?

Just started reviewing, give me a few minutes :)

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 13, 2017

Just started reviewing, give me a few minutes :)

Sorry didn't mean to put you in a hurry, just wanted to make you aware of this PR :-)

bergzand
bergzand requested changes Nov 13, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, single remark.

tests/gnrc_ipv6_ext/main.c Outdated
#include "net/gnrc/netif.h"
#include "net/gnrc/netif2.h"
#include "net/gnrc/netif/hdr.h"
#include "xtimer.h"
Copy link
Copy Markdown
Member

@bergzand bergzand Nov 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This include seems to be unecessary.

@bergzand
Copy link
Copy Markdown
Member

bergzand commented Nov 13, 2017

Sorry didn't mean to put you in a hurry, just wanted to make you aware of this PR :-)

No worries :)

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 13, 2017

Addressed.

@bergzand
Copy link
Copy Markdown
Member

bergzand commented Nov 13, 2017

Ack, ready to squash.

@miri64 miri64 force-pushed the gnrc_netif2/fix/7424-follow-up branch from e5c8793 to 7a833f8 Compare November 13, 2017 15:37
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 13, 2017

Squashed

bergzand
bergzand approved these changes Nov 13, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@miri64 miri64 mentioned this pull request Nov 13, 2017
Merged
3 tasks
@miri64 miri64 merged commit b573348 into RIOT-OS:gnrc_netif2_integration/master Nov 13, 2017
@miri64 miri64 deleted the gnrc_netif2/fix/7424-follow-up branch November 20, 2017 13:30
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergzand bergzand bergzand approved these changes

@smlng smlng Awaiting requested review from smlng

Assignees

@bergzand bergzand

@smlng smlng

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2018.01

Development

Successfully merging this pull request may close these issues.

4 participants

@miri64 @smlng @bergzand @aabadie