sys/net/gnrc_netif2: port sx127x to netif2#7950
sys/net/gnrc_netif2: port sx127x to netif2#7950aabadie wants to merge 8 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
Conversation
|
Can you give this PR a proper name, please. |
| "sx127x", (netdev_t *)&sx127x_devs[i]); | ||
| #else | ||
| gnrc_netdev_init(sx127x_stacks[i], SX127X_STACKSIZE, SX127X_PRIO, | ||
| "sx127x", &sx127x_netdevs[i]); |
There was a problem hiding this comment.
This isn't necessary anymore, please remove all the #ifdefs
aabadie
changed the title
PR title updated, not sure if it's ok now ;) |
| sx127x_setup(&sx127x_devs[i], &sx127x_params[i]); | ||
| #ifdef MODULE_GNRC_NETIF2 | ||
| gnrc_netif2_raw_create(sx127x_stacks[i], SX127X_STACKSIZE, SX127X_PRIO, | ||
| "sx127x", (netdev_t *)&sx127x_devs[i]); |
There was a problem hiding this comment.
I don't think you want to use raw, but the LoRA layer. Otherwise you don't get any link-layer headers.
aabadie
force-pushed
the
pr/auto_init_sx127x_netif2
branch
from
65b0625 to
a03f06e
Compare
Done, I think. |
boards/b-l072z-lrwan1/Makefile.dep
Outdated
| @@ -1,3 +1,7 @@ | |||
| ifneq (,$(filter gnrc_netdev_default netdev_default,$(USEMODULE))) | |||
There was a problem hiding this comment.
The gnrc_netdev_default case isn't required anymore, even in master ;-)
| */ | ||
| #define SX127X_STACKSIZE (THREAD_STACKSIZE_DEFAULT) | ||
| #ifndef SX127X_PRIO | ||
| #define SX127X_PRIO (GNRC_NETDEV_MAC_PRIO) |
There was a problem hiding this comment.
Please use GNRC_NETIF2_MAC_PRIO instead.
aabadie
force-pushed
the
pr/auto_init_sx127x_netif2
branch
from
a03f06e to
c6fc4ad
Compare
|
@miri64, is it fine if I close this one and wait for the new gnrc netif to arrive in master ? |
|
You can close it or adapt it as soon as it is in master. As you prefer :-). |
Since it's targeting another branch than master, I think I'll have to close it in both cases. So let's do it now :) |
|
(I know why, but for posterity) Why did you close this PR? |
I think it's not possible to change the target branch in a PR on GitHub (but maybe I'm wrong). |
|
It is. Just click on "Edit" next to the PR title above and change it ;-). |
Ah ! Thanks for the tip :) |
2 participants
This is an attempt to port the SX127x driver to gnrc_netdev and gnrc_netif2 in the mean time.
This PR is adaption of #7356 for netif2.
Building the default example for b-l072z-lrwan1 fails and I don't understand why. Any help would be highly appreciated.