Skip to content

tests/gnrc_ipv6_nib_6ln: Fix error w/ clang on macOS#7911

Merged
miri64 merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
x3ro:fix-gnrc-ipv6-nib-6ln
Nov 7, 2017
Merged

tests/gnrc_ipv6_nib_6ln: Fix error w/ clang on macOS#7911
miri64 merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
x3ro:fix-gnrc-ipv6-nib-6ln

Conversation

@x3ro
Copy link
Copy Markdown
Contributor

@x3ro x3ro commented Oct 30, 2017

_is_reachable is only used when GNRC_IPV6_NIB_CONF_ARSM
is enabled, and as such it must be guarded so that clang
doesn't complain about a unused function in case
GNRC_IPV6_NIB_CONF_ARSM is not set

Similar to #7910
Relates to 6473

@x3ro x3ro added OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 30, 2017
@x3ro x3ro requested a review from miri64 October 30, 2017 11:45
@miri64
Copy link
Copy Markdown
Member

miri64 commented Oct 30, 2017

In accordance to refactoring work on GNRC and the current merge embargo for GNRC, can you rebase this branch against gnrc_netif2_integration/master, please?

@miri64 miri64 self-assigned this Nov 1, 2017
@miri64 miri64 changed the base branch from master to gnrc_netif2_integration/master November 1, 2017 08:59
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 1, 2017

Ping @x3ro?

_is_reachable is only used when GNRC_IPV6_NIB_CONF_ARSM
is enabled, and as such it must be guarded so that clang
doesn't complain about a unused function in case
GNRC_IPV6_NIB_CONF_ARSM is not set

Similar to #7910
Relates to 6473
@x3ro x3ro force-pushed the fix-gnrc-ipv6-nib-6ln branch from 736c874 to 4bb12ba Compare November 7, 2017 16:33
@x3ro
Copy link
Copy Markdown
Contributor Author

x3ro commented Nov 7, 2017

Done @miri64, sorry for the delay

Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit de591ca into RIOT-OS:gnrc_netif2_integration/master Nov 7, 2017
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants