Skip to content

samd21/clock: add OSCULP32K/DFLL option#7826

Closed
Hyungsin wants to merge 2 commits intoRIOT-OS:masterfrom
Hyungsin:hamilton-clock
Closed

samd21/clock: add OSCULP32K/DFLL option#7826
Hyungsin wants to merge 2 commits intoRIOT-OS:masterfrom
Hyungsin:hamilton-clock

Conversation

@Hyungsin
Copy link
Copy Markdown

@Hyungsin Hyungsin commented Oct 24, 2017 •
edited
Loading

This PRR adds OSCULP32K/DFLL clock option for samd21.
This also allows xtimer to use 32kHz OSCULP32K/RTT timer to provide low power sleep mode.

@thomaseichinger may be a good reviewer.

@photonthunder
Copy link
Copy Markdown

photonthunder commented Oct 24, 2017

PR #7315 attempts to address the need for having different sources running different peripherals. It would make your additions even easier because then you could just add an option to use the OSCULP32k instead of XOSC32k (rather then duplicate so much code). It also sets up OSCULP32k as gen3.

@Hyungsin
Copy link
Copy Markdown
Author

Hyungsin commented Oct 25, 2017

@photonthunder, Cool.
Then I need to rework after #7315 is merged.

@miri64 miri64 added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Oct 28, 2017
@Hyungsin
Copy link
Copy Markdown
Author

Hyungsin commented Nov 22, 2017

Any review here?

@Hyungsin
Copy link
Copy Markdown
Author

Hyungsin commented Apr 18, 2018 •
edited
Loading

@thomaseichinger , @haukepetersen.
It takes longer than I thought to merge #7315.
Is it possible to merge this PR first?

@Hyungsin Hyungsin mentioned this pull request Apr 24, 2018
Merged
@stale
Copy link
Copy Markdown

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaseichinger thomaseichinger Awaiting requested review from thomaseichinger

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees

@thomaseichinger thomaseichinger

@haukepetersen haukepetersen

Labels

Platform: ARM Platform: This PR/issue effects ARM-based platforms State: stale State: The issue / PR has no activity for >185 days Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hyungsin @photonthunder @thomaseichinger @haukepetersen @miri64