Skip to content

make: add feature dependencies to drivers/Makefile.dep#7773

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:fix_driver_feature_deps
Nov 2, 2017
Merged

make: add feature dependencies to drivers/Makefile.dep#7773
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:fix_driver_feature_deps

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 commented Oct 19, 2017

Many drivers depend on certain features (e.g., periph_spi) without explicitly stating so.

This PR tries to add the missing dependencies.

WIP for now, help welcome! ;)

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: help wanted The contributors require help from other members of the community labels Oct 19, 2017
@kaspar030 kaspar030 force-pushed the fix_driver_feature_deps branch from 4aa58c2 to d03844e Compare October 28, 2017 19:10
@kaspar030 kaspar030 changed the title WIP: add feature dependencies to drivers/Makefile.dep make: add feature dependencies to drivers/Makefile.dep Oct 28, 2017
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kaspar030 kaspar030 merged commit efa36ab into RIOT-OS:master Nov 2, 2017
@kaspar030
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing!

@kaspar030 kaspar030 deleted the fix_driver_feature_deps branch November 2, 2017 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: help wanted The contributors require help from other members of the community Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants