Skip to content

tests: pkg_fatfs: add periph_rtc to required features#7772

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:add_tests_pkg_fatfs_rtc_dep
Nov 2, 2017
Merged

tests: pkg_fatfs: add periph_rtc to required features#7772
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:add_tests_pkg_fatfs_rtc_dep

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

The tests reqiures a periph/rtc implementation to be available.
This is currently insured through whitelisting, but the whitelist will go as soon as #6063 is resolved.

This PR adds an explicit requirement.

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework labels Oct 19, 2017
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 19, 2017
@kaspar030
Copy link
Copy Markdown
Contributor Author

This should be more than low-hanging. ;)

@bergzand
Copy link
Copy Markdown
Member

Is it possible to remove the FATFS_FFCONF_OPT_FS_NORTC on line 353 if the RTC is required anyway?

@MichelRottleuthner
Copy link
Copy Markdown
Contributor

@bergzand the RTC is no mandatory feature for FatFs to work. You can still use it without RTC. Of course you won't get proper timestamps on your files then.

@bergzand
Copy link
Copy Markdown
Member

@MichelRottleuthner Yes, that's what I understood from the documentation. I'm asking the question because @kaspar030 add the periph_rtc to the required modules in this PR for the fatfs test.

If the RTC is considered a requirement for the test in the makefile, why then make it optional in the code.

@MichelRottleuthner
Copy link
Copy Markdown
Contributor

Makes sense. I would argue that you don't really gain a benefit by adding the RTC as hard dependency. The test doesn't check timestamp relevant stuft at the moment. With adding the RTC as hard dependency you would disable testing for platforms that come without RTC support. If I remeber correctly I just wanted to enable the RTC feature for Boards that actually come with an RTC.

@haukepetersen
Copy link
Copy Markdown
Contributor

looking at pkg/fatfs/Makefile.dep: I think it sould be FEATURES_OPTIONAL here, right?

@kaspar030 kaspar030 force-pushed the add_tests_pkg_fatfs_rtc_dep branch from 513c366 to 5278db6 Compare November 2, 2017 11:54
@kaspar030
Copy link
Copy Markdown
Contributor Author

looking at pkg/fatfs/Makefile.dep: I think it sould be FEATURES_OPTIONAL here, right?

Yes, done!

Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kaspar030 kaspar030 force-pushed the add_tests_pkg_fatfs_rtc_dep branch from 5278db6 to d0fece7 Compare November 2, 2017 14:06
@kaspar030
Copy link
Copy Markdown
Contributor Author

&go.

@kaspar030 kaspar030 merged commit c9448f4 into RIOT-OS:master Nov 2, 2017
@kaspar030 kaspar030 deleted the add_tests_pkg_fatfs_rtc_dep branch November 2, 2017 14:18
@jnohlgard jnohlgard added the Area: fs Area: File systems label Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: fs Area: File systems Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants