tests: pkg_fatfs: add periph_rtc to required features#7772
tests: pkg_fatfs: add periph_rtc to required features#7772kaspar030 merged 1 commit intoRIOT-OS:masterfrom
Conversation
|
This should be more than low-hanging. ;) |
|
Is it possible to remove the |
|
@bergzand the RTC is no mandatory feature for FatFs to work. You can still use it without RTC. Of course you won't get proper timestamps on your files then. |
|
@MichelRottleuthner Yes, that's what I understood from the documentation. I'm asking the question because @kaspar030 add the If the RTC is considered a requirement for the test in the makefile, why then make it optional in the code. |
|
Makes sense. I would argue that you don't really gain a benefit by adding the RTC as hard dependency. The test doesn't check timestamp relevant stuft at the moment. With adding the RTC as hard dependency you would disable testing for platforms that come without RTC support. If I remeber correctly I just wanted to enable the RTC feature for Boards that actually come with an RTC. |
|
looking at |
513c366 to
5278db6
Compare
Yes, done! |
5278db6 to
d0fece7
Compare
|
&go. |
The tests reqiures a periph/rtc implementation to be available.
This is currently insured through whitelisting, but the whitelist will go as soon as #6063 is resolved.
This PR adds an explicit requirement.