Skip to content

core: clist: improve clist_foreach()#7768

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:improve_clist_foreach
Nov 6, 2017
Merged

core: clist: improve clist_foreach()#7768
miri64 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:improve_clist_foreach

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 commented Oct 19, 2017 •
edited
Loading

previously, clist_foreach() allowed to iterate a list, executing a function for every member, and possibly aborting.

This PR adds an opaque void* argument to the function call, allowing clist_foreach() to be used in more flexible ways.

Waiting for #7655. (not directly dependent on it, but I'd like to save the hassle of rebasing, and they modify the same files)

@kaspar030 kaspar030 added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Area: core Area: RIOT kernel. Handle PRs marked with this with care! Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 19, 2017
@kaspar030 kaspar030 force-pushed the improve_clist_foreach branch from 327079b to d272f2d Compare October 19, 2017 14:38
@kaspar030 kaspar030 force-pushed the improve_clist_foreach branch from d272f2d to 615b1e6 Compare November 6, 2017 11:49
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 6, 2017
miri64
miri64 approved these changes Nov 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I don't have to tell you that this basically has implications on our core-codesize ;-).

ACK (needs second ACK though, I believe)

@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 6, 2017

(needs second ACK though, I believe)

only just saw the minor label and I I agree. Go!

@miri64 miri64 merged commit e35ebf4 into RIOT-OS:master Nov 6, 2017
@kaspar030 kaspar030 deleted the improve_clist_foreach branch January 22, 2019 10:22
@danpetry danpetry modified the milestone: Release 2019.04 Mar 12, 2019
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@miri64 miri64

@OlegHahm OlegHahm

Labels

Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaspar030 @miri64 @OlegHahm @danpetry