kinetis: Change ISR names to match vendor header IRQ names#7761
kinetis: Change ISR names to match vendor header IRQ names#7761jnohlgard wants to merge 13 commits intoRIOT-OS:masterfrom
Conversation
jnohlgard
added
Platform: ARM
jnohlgard
force-pushed
the
pr/kinetis-isr-names
branch
from
8389bd8 to
4a0bce1
Compare
According to NXP material, there are no 100 MHz K22F parts in 144 pin packages, which is the reference manual that this header is supposed to correspond to. The header was originally included from Keil uVision Kinetis support packages. It is possible that this header was only used with engineering samples of the K22F.
jnohlgard
force-pushed
the
pr/kinetis-isr-names
branch
from
4a0bce1 to
5cb62ad
Compare
|
On first sight, I am not too happy with this change. Having the vector names following the coding rules makes the code just so much nicer to look at, and I more pressingly feel that if we start to make an exception to the rules here, people will start to make these exceptions in many other places (be it for good reasons or not), leading to a more incoherent code base... But maybe I am to picky here?!
I see the point, but I imagine that this test is mostly done automatically using some kind of script, right? In that case, I think it is easy to convert a string from upper to lower case. Also when using some kind of regex to do these checks, it is mostly also simple to ignore the case. But in the end I stated my doubts, but I will not block this PR if it is decided to go with it, I just won't be the one merging this :-) |
|
@haukepetersen would you be more ok with this if I change all isr names into lowercase, but the same names as they have in this PR? |
|
#7878 was merged, deleting this branch |
2 participants
This PR changes the names of the interrupt service routines (ISR) to match the corresponding interrupt request (IRQ) name in the vendor headers, as closely as possible. This will make maintaining multiple CPU ports easier, and the peripheral configuration will become easier as well since the names make more sense.
The new naming breaks some coding conventions by using CamelCase and uppercase letters for these functions, but all are prefixed with
isr_, like the coding conventions dictate.Use case: As a side project, I am working on merging all Kinetis CPUs into a single cpu directory to reduce code duplication. It will be easier to maintain and add new CPUs if the vectors can be partially generated directly from vendor headers. It will be easier to verify the implementation when the vector table in the binary can be compared with the IRQ list in the vendor header.