cpu/stm32: optimized definition of CPUID_ADDR#7731
cpu/stm32: optimized definition of CPUID_ADDR#7731haukepetersen merged 1 commit intoRIOT-OS:masterfrom
Conversation
haukepetersen
added
Platform: ARM
vincent-d
left a comment
vincent-d
left a comment
There was a problem hiding this comment.
Code-wise, it looks OK, feel free to fix my comment and amend -> Untested ACK
| /** | ||
| * @name Starting address of the CPU ID | ||
| */ | ||
| #ifdef CPU_MODEL_STM32F722ZE |
There was a problem hiding this comment.
Minor nit: everything is lowercase except the A
There was a problem hiding this comment.
copy pasta, will fix
kYc0o
left a comment
kYc0o
left a comment
There was a problem hiding this comment.
ACK. I'll rebase mine after this one and remove all cpuid related definitions.
haukepetersen
force-pushed
the
opt_stm32_cpuid
branch
from
8fda1b1 to
625cba4
Compare
|
fixed upper case issue and squashed it right in. |
|
I tested successfully in the boards I have but since the change touches quite a lot of boards I'm unsure... @haukepetersen if you think everything should work you're free to push the green button ;-) |
haukepetersen
force-pushed
the
opt_stm32_cpuid
branch
from
625cba4 to
39f715e
Compare
haukepetersen
force-pushed
the
opt_stm32_cpuid
branch
from
39f715e to
5a35517
Compare
|
Did a careful review once more and tested all STMs that I have laying around here: now I am confident that this PR does not brake anything -> go. |
6 participants
This PR removes a lot of redundant information, as (with very few exceptions) the members of the stm32 families use the same CPUID offset address. So no need to specify if for each CPU_MODEL.
Further: removing this value from the linker scripts takes away a difference between stm32 and other cortex CPU families, so we can actually used shared linkerscripts (see #7729).