boards/sodaq-explorer: add initial support by aabadie · Pull Request #7725 · RIOT-OS/RIOT

aabadie · 2017-10-12T10:12:15Z

This PR adds a basic support for the Sodaq LoRaWAN ExpLoRer kit board.

What has been tested with success:

UARTs
GPIOs via SAUL (on-board LED and button)
RTT with tests/periph_rtt
RTC with tests/periph_rtc
ADC with tests/periph_adc

I2C and SPI have not been tested.

Since no PWM is defined, this PR relies on #7724

keestux · 2017-10-12T19:20:52Z

Nice. This is the SODAQ ExpLoRer.
Wow, I didn't know we could use the default bootloader and burn via bossac. Great.

keestux

ACK. Thanks for doing this.

keestux · 2017-10-12T19:21:33Z

boards/lorawan-explorer/Makefile.include

@@ -0,0 +1,20 @@
+# define the cpu used by Arduino/Genuino MKR1000 board


This should be SODAQ ExpLoRer, I guess.

smlng

IMO the board is rather recognise as the SODAQ ExpLoRer hence we should usesodaq-explorer as the official board name, otherwise it might not be recognised by others.

aabadie · 2017-10-12T20:15:53Z

This is the SODAQ ExpLoRer.

I was unsure of what was the best, I'll change that

smlng · 2017-10-12T20:02:59Z

boards/lorawan-explorer/include/board.h

+#define LED0_PORT           PORT->Group[PA]
+#define LED0_MASK           (1 << 21)
+
+#define LED0_ON             (LED0_PORT.OUTSET.reg = LED0_MASK)


not sure but shouldn't these rather use |=?

nevermind, found that other boards of that cpu (family) use it the same.

smlng · 2017-10-12T20:29:57Z

@aabadie, regarding the board name: I prefer sodaq-explorer, basically looks like 1:1 here - but as @keestux also used that name twice above, there is kind of a trend 😉 If you agree, too, I suggest to go for sodaq-explorer.

Looks like a nice board with good online docu!

aabadie · 2017-10-12T20:31:17Z

Just made the change @smlng @keestux and extended a bit the documentation

haukepetersen

Looking good! Just two minor remarks.

haukepetersen · 2017-10-13T08:53:50Z

boards/sodaq-explorer/doc.txt

+ *
+ * ### Accessing STDIO via UART
+ *
+ * To access the STDIO of RIOT, a FTDI to USB converted needs to be plugged to


s/converted/converter/?

haukepetersen · 2017-10-13T08:55:35Z

boards/sodaq-explorer/include/gpio_params.h

+    {
+        .name = "LED",
+        .pin = LED0_PIN,
+        .mode = GPIO_OUT


does it make sense to adapt this also to #7586 (setting polarity and initial state) from the start?!

Not for the LED since it's not inverted. I changed that for the button

haukepetersen · 2017-10-13T08:56:39Z

Also, #7724 is merged, so you can rebase :-)

aabadie · 2017-10-13T09:32:52Z

@haukepetersen, comments addressed and branch rebased

haukepetersen

ACK

haukepetersen · 2017-10-13T12:02:15Z

oh, for completeness: the ACK is untested as I don't have the hw...

aabadie · 2017-10-13T12:05:11Z

I have to remove this board from the unittests, Murdock is failing because of this

aabadie · 2017-10-13T12:44:12Z

Murdock is finally happy, @smlng do you ACK ?

smlng · 2017-10-13T14:26:31Z

boards/sodaq-explorer/Makefile.include

+export LINKER_SCRIPT ?= $(RIOTCPU)/sam0_common/ldscripts/$(CPU_MODEL)_arduino_bootloader.ld
+include $(RIOTMAKE)/tools/bossa.inc.mk
+
+INCLUDES += -I$(RIOTBOARD)/lorawan-explorer/include


missed that, replace /lorawan-explorer/sodaq-explorer/, or even better with $(BOARD) - thought murdock would find such things?

actually I think, this isn't needed at all, just for boards that depend on some common includes.

smlng · 2017-10-13T14:29:26Z

boards/sodaq-explorer/include/periph_conf.h

+ * @{
+ *
+ * @file
+ * @brief       Configuration of CPU peripherals for the Sodaq LoRaWAN Explorer board


nit picky, but consistent with other files here would be Configuration of CPU peripherals for the SODAQ ExpLoRer board

smlng · 2017-10-13T14:31:49Z

boards/sodaq-explorer/include/board.h

+#ifdef __cplusplus
+extern "C" {
+#endif
+


with #6702 merge you need to add

/** * @name xtimer configuration * @{ */ #define XTIMER_WIDTH (16) /** @} */

or use TIMER1 for xtimer with default with of 32 bits

I kept the 16 bit version

did you run any of the tests/xtimer_* to verify, because this must be tested at runtime, otherwise Murdock would've complained already.

I tested with xtimer_msg, works well.

thx for reporting, ACK then

xtimer_drift is good test to run for an overall sanity check of the hardware timer. It will show you if the timer is misconfigured, for example running at slower or faster than expected. It should print one message per second if everything is working properly.

I ran this one as well and had the expected behaviour ;)

aabadie · 2017-10-13T15:26:53Z

@smlng, comments addressed

smlng

final question before ACK 😉

smlng · 2017-10-13T15:56:12Z

boards/sodaq-explorer/include/board.h

+#ifdef __cplusplus
+extern "C" {
+#endif
+


did you run any of the tests/xtimer_* to verify, because this must be tested at runtime, otherwise Murdock would've complained already.

aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Oct 12, 2017

aabadie added this to the Release 2017.10 milestone Oct 12, 2017

aabadie requested review from haukepetersen and keestux October 12, 2017 10:12

keestux approved these changes Oct 12, 2017

View reviewed changes

smlng suggested changes Oct 12, 2017

View reviewed changes

keestux mentioned this pull request Oct 12, 2017

boards/sodaq-autonomo: correct TX pin of uart2 #7728

Merged

smlng reviewed Oct 12, 2017

View reviewed changes

aabadie force-pushed the board/lorawan-explorer branch from d302163 to 23fccf8 Compare October 12, 2017 20:30

aabadie changed the title ~~boards/lorawan-explorer: add initial support~~ boards/sodaq-explorer: add initial support Oct 12, 2017

aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 12, 2017

aabadie force-pushed the board/lorawan-explorer branch 2 times, most recently from f2e6632 to d6cba4c Compare October 12, 2017 20:51

kYc0o mentioned this pull request Oct 13, 2017

[WIP] Factorise stm32 and sam0 linker scripts #7729

Closed

50 tasks

aabadie force-pushed the board/lorawan-explorer branch from d6cba4c to 99095b5 Compare October 13, 2017 06:30

aabadie added Area: boards Area: Board ports Area: LoRa Area: LoRa radio support labels Oct 13, 2017

haukepetersen requested changes Oct 13, 2017

View reviewed changes

aabadie mentioned this pull request Oct 13, 2017

boards/sodaq-explorer: add configuration for rn2483 module #7733

Merged

aabadie force-pushed the board/lorawan-explorer branch from 99095b5 to e2c36e1 Compare October 13, 2017 09:28

haukepetersen approved these changes Oct 13, 2017

View reviewed changes

cpu/sam0: adapt support for samd21j18a with bootloader

eef753a

aabadie force-pushed the board/lorawan-explorer branch from cc7ff6b to d984cf8 Compare October 13, 2017 12:23

smlng suggested changes Oct 13, 2017

View reviewed changes

aabadie added 2 commits October 13, 2017 17:24

boards/sodaq-explorer: initial support

e5db719

tests/unittests: skip sodaq-explorer

316e842

aabadie force-pushed the board/lorawan-explorer branch from d984cf8 to 316e842 Compare October 13, 2017 15:24

smlng reviewed Oct 13, 2017

View reviewed changes

smlng approved these changes Oct 13, 2017

View reviewed changes

aabadie removed the Platform: ARM Platform: This PR/issue effects ARM-based platforms label Oct 13, 2017

smlng merged commit 7e388b2 into RIOT-OS:master Oct 13, 2017

aabadie deleted the board/lorawan-explorer branch February 26, 2018 10:33

		@@ -0,0 +1,20 @@
		# define the cpu used by Arduino/Genuino MKR1000 board

Conversation

aabadie commented Oct 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keestux commented Oct 12, 2017

Uh oh!

keestux left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smlng left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie commented Oct 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smlng commented Oct 12, 2017

Uh oh!

aabadie commented Oct 12, 2017

Uh oh!

haukepetersen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Oct 13, 2017

Uh oh!

aabadie commented Oct 13, 2017

Uh oh!

haukepetersen left a comment

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Oct 13, 2017

Uh oh!

aabadie commented Oct 13, 2017

Uh oh!

aabadie commented Oct 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie commented Oct 13, 2017

Uh oh!

smlng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

aabadie commented Oct 12, 2017 •

edited

Loading

smlng left a comment •

edited

Loading