Skip to content

cpu/samd21: skip pwm if not defined in board config#7724

Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/cpu_samd21_pwm
Oct 13, 2017
Merged

cpu/samd21: skip pwm if not defined in board config#7724
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/cpu_samd21_pwm

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Oct 12, 2017

While working on a board port, I realized that pwm driver was not guarded in case no pwm is configured.

This PR brings a fix for that potential problem.

Should be fast to review

@aabadie aabadie requested a review from haukepetersen October 12, 2017 10:10
@aabadie aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 12, 2017
@aabadie aabadie added this to the Release 2017.10 milestone Oct 12, 2017
@aabadie aabadie mentioned this pull request Oct 12, 2017
Merged
haukepetersen
haukepetersen approved these changes Oct 12, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as temporary fix -> hope we have the selectively building of periph drivers in soon...

ACK for now

@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Oct 13, 2017

all green -> go

@haukepetersen haukepetersen merged commit fdc79ae into RIOT-OS:master Oct 13, 2017
@aabadie aabadie deleted the pr/cpu_samd21_pwm branch February 26, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haukepetersen haukepetersen haukepetersen approved these changes

Assignees

No one assigned

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2017.10

Development

Successfully merging this pull request may close these issues.

2 participants

@aabadie @haukepetersen