Merged
Conversation
miri64
added
Type: bug
smlng
suggested changes
Oct 12, 2017
| #ifdef MODULE_FIB | ||
| ipv6_addr_t defroute = IPV6_ADDR_UNSPECIFIED; | ||
|
|
||
| ipv6_addr_from_str(&defroute, "::"); |
Member
There was a problem hiding this comment.
this looks obsolete with defroute set above, or not?
Member
Author
There was a problem hiding this comment.
Yes, wanted to remove it, but somehow forgot ^^
Member
|
please squash and trigger Murdock |
\RIOT-OS#7721 showed, that `posix` is required to include the `arpa/inet.h` header into the include path of an application using the `uhcpc` module. Additionally this PR makes the FIB an optional dependency of `gnrc_uhcpc`.
miri64
force-pushed
the
gnrc_uhcpc/fix/dep
branch
from
c7737cb to
cb2a968
Compare
Member
Author
|
Squashed |
smlng
added
the
CI: ready for build
Member
Author
|
@smlng ping? |
miri64
added
CI: ready for build
smlng
approved these changes
Nov 6, 2017
Member
Author
|
Arghs we forgot about the GNRC-embargo here :-/ |
Member
Author
|
This PR is the reason for the merge problems in #7925... will backport to that PR it ASAP |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 8, 2017
\RIOT-OS#7721 showed, that `posix` is required to include the `arpa/inet.h` header into the include path of an application using the `uhcpc` module. Additionally this PR makes the FIB an optional dependency of `gnrc_uhcpc`. Backport of RIOT-OS#7722
This was referenced Nov 8, 2017
bergzand
pushed a commit
to bergzand/RIOT
that referenced
this pull request
Nov 17, 2017
\RIOT-OS#7721 showed, that `posix` is required to include the `arpa/inet.h` header into the include path of an application using the `uhcpc` module. Additionally this PR makes the FIB an optional dependency of `gnrc_uhcpc`. Backport of RIOT-OS#7722
bergzand
pushed a commit
to bergzand/RIOT
that referenced
this pull request
Nov 19, 2017
\RIOT-OS#7721 showed, that `posix` is required to include the `arpa/inet.h` header into the include path of an application using the `uhcpc` module. Additionally this PR makes the FIB an optional dependency of `gnrc_uhcpc`. Backport of RIOT-OS#7722
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7721 showed, that
posixis required to include thearpa/inet.hheader into the include path of an application using the
uhcpcmodule.
Additionally this PR makes the FIB an optional dependency of
gnrc_uhcpc.