boards: add initial support for ST b-l475e-iot01a by aabadie · Pull Request #7584 · RIOT-OS/RIOT

aabadie · 2017-09-08T11:03:12Z

Board datasheet is here, detailed pdf is here.

This board is very interesting for IoT:

it is low power: uses a STM32L475VG mcu
it embeds lots of radio devices: WiFi, BLE, NFC and LoRa
it embeds lots of sensors: microphone (MP34DT01), temperature/humidy(HTS221), magnetometer (LIS3MDL), accelerometer (LSM6DSL), pressure (LPS22HB), TOF ranging (VL53L0X)
it's arduino pinout compatible (not very important though)

I'll create an issue to keep track of the remaining things to do to fully support it.

Thanks to @kYc0o who pointed me to it :)

jnohlgard · 2017-09-08T11:11:55Z

That's a lot of connectivity options on one board.

aabadie · 2017-11-15T17:23:13Z

I received some gifts today with 2 of these boards in :)

Just tested it and this PR seems to work: I could play with the shell and on-board LEDs. I need to go further in testing and also rebase.

aabadie · 2017-11-17T10:47:48Z

The initial port was not that bad. I tested configured uart, timer, rtc, rtt with success.

Maybe @astralien3000 you can test the configured PWMs ?

haukepetersen

Minor remarks, else looks good.

But I'd say the discussion from #8058 applies here as well -> 90% of the lines in this PR are duplicates of existing code. But I am unsure we want to go ahead as is (and cleaup later), or if we want to wait merging this PR until some more clear structure for code sharing is agreed upon.

haukepetersen · 2017-11-17T11:04:40Z

boards/b-l475e-iot01a/Makefile.include

@@ -0,0 +1,13 @@
+## the cpu to build for


extra # char?!

haukepetersen · 2017-11-17T11:05:48Z

boards/b-l475e-iot01a/board.c

+    cpu_init();
+
+    /* initialize the boards LED */
+#ifdef AUTO_INIT_LED0


just to make sure: is this also the case on this board or is this just a copy/paste error from the nucleo code?

It's also the case on this board => same pin for LED_0 and SPI_0 clock

is this just a copy/paste error from the nucleo code?

hopefully all my code is not only copy paste

aabadie · 2017-11-17T11:16:43Z

the discussion from #8058 applies here as well -> 90% of the lines in this PR are duplicates of existing code

I know, that's why I'm very much in favour of the proposed solutions there (whichever is chosen). See my comment talking about the introduction of a boards/common/stm directory that also goes in that direction.

The board here and others from ST are sharing a lot of things (Arduino compatible pinout, ST-Link, etc)

aabadie · 2017-11-17T11:17:20Z

I would also like to have #7799 merged soon and rebase on it after

kYc0o · 2017-11-17T16:33:22Z

The board here and others from ST are sharing a lot of things (Arduino compatible pinout, ST-Link, etc)

Take a look at #7686 to adapt the debugger.

astralien3000 · 2017-11-20T10:12:11Z

Saul SENSE_BTN does not seem to work.

EDIT: it's C13 instead of B2

aabadie · 2017-11-20T12:47:07Z

it's C13 instead of B2

Thanks for having a look @astralien3000 ! Will fix

astralien3000 · 2017-11-20T14:03:39Z

I also tested PWMs, D9 is working, but not D5 and D6.
TIM3 is 16-bits instead of 32-bit for TIM2 (datasheet p45), maybe the problem comes from there ?

aabadie · 2017-11-20T16:33:51Z

@astralien3000, I fixed the wrong pin definitions and removed the 2 PWM that doesn't work as it seems to be a more general driver issue (not being able to change the timer width).

aabadie · 2017-11-20T16:37:27Z

@kYc0o, I addressed your comment regarding the debugger configuration. Still works !

aabadie · 2017-12-01T16:57:35Z

@kYc0o, now that #7799 is merged, I rebased this PR and remove the ld script. Just tested and it still works.

aabadie · 2017-12-11T08:00:02Z

@haukepetersen, @kYc0o, I think we are good with this one. I tested it again locally and it's still working.

kaspar030 · 2017-12-03T16:40:09Z

boards/b-l475e-iot01a/Makefile.features

+FEATURES_PROVIDED += periph_timer
+FEATURES_PROVIDED += periph_uart
+
+# Load extra provided features


remove this, cpp is provided by cortex-m

fernandoavita · 2017-12-15T12:34:59Z

The LED1 macros are not working due to a typo in the board.h file. They are defined with LED0_MASK instead of LED1_MASK.

Thanks adding support to this board! I would like to learn RIOT and I'm with this board in hands.

aabadie · 2017-12-15T12:38:35Z

The LED1 macros are not working due to a typo in the board.h file

Thanks for reporting @fernandoavita. I just pushed the fixed configuration. Can you test again ?

fernandoavita · 2017-12-15T12:59:08Z

I just pushed the fixed configuration. Can you test again ?

Sure! Now they are working. Thanks @aabadie!

haukepetersen

ACK

aabadie · 2017-12-15T14:13:11Z

@kaspar030 ? (now that your github notifications are fixed :) )

aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 8, 2017

aabadie added this to the Release 2017.10 milestone Sep 8, 2017

aabadie assigned haukepetersen and kYc0o Sep 8, 2017

aabadie force-pushed the b-l475e-iot01a branch 3 times, most recently from 9ae9325 to 637ef5e Compare September 8, 2017 11:15

aabadie mentioned this pull request Sep 9, 2017

Track support for ST b-l475e-iot01a board #7585

Open

12 tasks

aabadie force-pushed the b-l475e-iot01a branch from 637ef5e to 84df78b Compare September 12, 2017 14:15

aabadie added Area: boards Area: Board ports Area: LoRa Area: LoRa radio support labels Oct 13, 2017

kYc0o mentioned this pull request Oct 29, 2017

Low-level Hardware Support #7888

Closed

23 tasks

kYc0o removed this from the Release 2017.10 milestone Oct 30, 2017

aabadie force-pushed the b-l475e-iot01a branch 2 times, most recently from a309758 to c5b9575 Compare November 17, 2017 10:43

haukepetersen requested changes Nov 17, 2017

View reviewed changes

aabadie mentioned this pull request Nov 17, 2017

drivers/lis3mdl: adopt new parameters scheme and provide SAUL adaption #7949

Merged

aabadie force-pushed the b-l475e-iot01a branch from c5b9575 to bafbd41 Compare November 17, 2017 11:18

aabadie force-pushed the b-l475e-iot01a branch from bafbd41 to 9b53809 Compare November 20, 2017 16:32

aabadie force-pushed the b-l475e-iot01a branch from f0b048e to f703f98 Compare December 1, 2017 16:54

aabadie removed the Area: LoRa Area: LoRa radio support label Dec 7, 2017

aabadie force-pushed the b-l475e-iot01a branch 3 times, most recently from b61f0e0 to cda7355 Compare December 11, 2017 07:57

aabadie mentioned this pull request Dec 11, 2017

boards: gpio auto initialization and saul #8234

Closed

kaspar030 requested changes Dec 11, 2017

View reviewed changes

aabadie force-pushed the b-l475e-iot01a branch 2 times, most recently from b8386b9 to 1fd4ef1 Compare December 15, 2017 10:15

aabadie added 2 commits December 15, 2017 13:36

cpu: add support for stm32l475vg

ce27441

boards: add initial support for ST bl-475e-iot01a

54b889b

aabadie force-pushed the b-l475e-iot01a branch from 1fd4ef1 to 54b889b Compare December 15, 2017 12:37

haukepetersen approved these changes Dec 15, 2017

View reviewed changes

kaspar030 approved these changes Dec 15, 2017

View reviewed changes

kaspar030 merged commit 3738704 into RIOT-OS:master Dec 15, 2017

aabadie deleted the b-l475e-iot01a branch June 8, 2018 20:49

Conversation

aabadie commented Sep 8, 2017

Uh oh!

jnohlgard commented Sep 8, 2017

Uh oh!

aabadie commented Nov 15, 2017

Uh oh!

aabadie commented Nov 17, 2017

Uh oh!

haukepetersen left a comment

Choose a reason for hiding this comment

Uh oh!

haukepetersen Nov 17, 2017

Choose a reason for hiding this comment

Uh oh!

aabadie Nov 17, 2017

Choose a reason for hiding this comment

Uh oh!

haukepetersen Nov 17, 2017

Choose a reason for hiding this comment

Uh oh!

aabadie Nov 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie Nov 17, 2017

Choose a reason for hiding this comment

Uh oh!

aabadie commented Nov 17, 2017

Uh oh!

aabadie commented Nov 17, 2017

Uh oh!

kYc0o commented Nov 17, 2017

Uh oh!

astralien3000 commented Nov 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aabadie commented Nov 20, 2017

Uh oh!

astralien3000 commented Nov 20, 2017

Uh oh!

aabadie commented Nov 20, 2017

Uh oh!

aabadie commented Nov 20, 2017

Uh oh!

aabadie commented Dec 1, 2017

Uh oh!

aabadie commented Dec 11, 2017

Uh oh!

kaspar030 Dec 3, 2017

Choose a reason for hiding this comment

Uh oh!

aabadie Dec 15, 2017

Choose a reason for hiding this comment

Uh oh!

fernandoavita commented Dec 15, 2017

Uh oh!

aabadie commented Dec 15, 2017

Uh oh!

fernandoavita commented Dec 15, 2017

Uh oh!

haukepetersen left a comment

Choose a reason for hiding this comment

Uh oh!

aabadie commented Dec 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aabadie Nov 17, 2017 •

edited

Loading

astralien3000 commented Nov 20, 2017 •

edited

Loading