Skip to content

boards/arduino-nano: port arduino nano board#7540

Closed
lebrush wants to merge 1 commit intoRIOT-OS:masterfrom
lebrush:feat/arduino-nano
Closed

boards/arduino-nano: port arduino nano board#7540
lebrush wants to merge 1 commit intoRIOT-OS:masterfrom
lebrush:feat/arduino-nano

Conversation

@lebrush
Copy link
Copy Markdown
Member

@lebrush lebrush commented Aug 30, 2017

No description provided.

@lebrush lebrush added Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: doc Area: Documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer and removed Area: doc Area: Documentation labels Aug 30, 2017
@miri64 miri64 requested a review from aabadie September 19, 2017 12:23
@lebrush lebrush added this to the Release 2017.10 milestone Oct 6, 2017
@lebrush lebrush added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 6, 2017
smlng
smlng suggested changes Oct 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the typo reveals the otherwise obvious: this is a copy of the arduino-uno by just adapting names. Like with the plague of nucleo this will make things hard to maintain/update in the future - not a fault of this PR, though but still worth mentioning.

boards/arduino-nano/include/board.h Outdated
*/

/**
* @defgroup boards_arduino-uno Arduino Nano
Copy link
Copy Markdown
Member

@smlng smlng Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/uno/nano/

@lebrush lebrush force-pushed the feat/arduino-nano branch from 9340d0b to 259f5c2 Compare October 6, 2017 08:55
@lebrush lebrush force-pushed the feat/arduino-nano branch from 259f5c2 to 916d6ab Compare October 6, 2017 08:57
@lebrush
Copy link
Copy Markdown
Member Author

lebrush commented Oct 6, 2017 •
edited
Loading

Thanks for the super quick review @smlng.
It's in fact a very good point, but until a solution is provided this is the only way to support a new board...

Comment addressed, btw.

@smlng
Copy link
Copy Markdown
Member

smlng commented Oct 6, 2017

in theory with #7227, there is a difference between uno and nano, because the former has 6 ADC and the latter 8. But such minor diffs can be handled in common board/periph configs.

@lebrush
Copy link
Copy Markdown
Member Author

lebrush commented Oct 6, 2017

True, unfortunately, how the atmega boards are supported nowadays, everything is handled in the atmega-atmega-common folder.

@smlng smlng mentioned this pull request Nov 13, 2017
Closed
sebastiankliem added a commit to sebastiankliem/RIOT that referenced this pull request Dec 28, 2017
@sebastiankliem
add support for Arduino Nano, taken and updated from RIOT-OS#7540 by @…
77d1b53 
…lebrush (https://github.com/lebrush)
@sebastiankliem
Copy link
Copy Markdown

sebastiankliem commented Jan 4, 2018

I've used your port for an university project and recognized that some referenced directories have changed. I fixed this in this commit: sebastiankliem@77d1b53

@sebastiankliem sebastiankliem mentioned this pull request Jan 4, 2018
Closed
@smlng smlng removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 15, 2018
smlng
smlng suggested changes Jan 15, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be adapted to #8058

@smlng
Copy link
Copy Markdown
Member

smlng commented Jan 15, 2018

@lebrush can you quickly rebase and adapt, I would merge this for release 2018.01 and if possible.

@ghost
Copy link
Copy Markdown

ghost commented Mar 15, 2018

Hi @lebrush, i am very interested in using the nano with riot, are you going to adapt the requested changes soon?

@kaspar030 kaspar030 removed this from the Release 2018.04 milestone Apr 16, 2018
@maribu
Copy link
Copy Markdown
Member

maribu commented Jul 4, 2018

As this PR is apparently dead, I created a new PR providing support for the Arduino Nano

@maribu maribu mentioned this pull request Jul 5, 2018
Merged
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jul 5, 2018

@maribu I guess it's ok after that time. Closing this PR in favor of #9499. Tanks @lebrush anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie Awaiting requested review from aabadie

1 more reviewer

@smlng smlng smlng requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aabadie aabadie

@smlng smlng

Labels

Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: AVR Platform: This PR/issue effects AVR-based platforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lebrush @smlng @sebastiankliem @maribu @PeterKietzmann @aabadie @kaspar030