Conversation
A-Paul
added
Platform: AVR
|
Why not go all the way here? The common file already contains a lot of `#ifdef' blocks, so why not make them specific to each atmega based board right away? This would be much cleaner... |
@haukepetersen because that would be a shitload of work for me. Just kidding... |
smlng
left a comment
smlng
left a comment
There was a problem hiding this comment.
there is also the atmega1281 used in the waspmote-pro, which should be considered here, too, but is currently missing.
| * @{ | ||
| */ | ||
| #ifdef CPU_ATMEGA328P | ||
| #define TIMER_NUMOF (2U) |
There was a problem hiding this comment.
looks like there actually only 1 timer, right?
| #define TIMER_0_FLAG &TIFR1 | ||
| #define TIMER_0_ISRA TIMER1_COMPA_vect | ||
| #define TIMER_0_ISRB TIMER1_COMPB_vect | ||
| #define TIMER_0_ISRC TIMER1_COMPC_vect |
There was a problem hiding this comment.
could be simplified to this line by removing #ifdef CPU_ATMEGA328P above
|
From the title I can't tell what this PR is about. Please update. |
|
Closing because of already restructured boards/common tree. |
4 participants
This is a preparation for implemeting a PWM driver for the atmeg328p MCU. The periph_conf has not been prepared for board specific configurations.
I just placed a periph_conf.h in the common include directory, which works fine. If it is copied to the board specific include directory then the make system selects that instead.
@miri64 for the board definitions you have placed a empty board.h in every specific include directory and none in the common. Are there reasons to prefer that schema?