boards/feather-m0: initial support by aabadie · Pull Request #7510 · RIOT-OS/RIOT

aabadie · 2017-08-24T13:19:32Z

Add support for Adafruit Feather M0 board. This board is the base boards used for:

Those boards are all the same, except that they have a different module soldered on them. All extra modules are connected to the same SPI (SPIDEV(0)). So the idea will be to add a <driver>_params.h in boards/feather-m0 when one is available (for example, RIOT doesn't support ATWINC1500 for the moment).

They are very similar to the Arduino MKR boards: same MCU (samd21g18a), can be flashed using bossa (since it uses the same bootloader preinstalled), same ldscript.

Only on-board LED, UART, 2 PWM, 6 ADC, 1 SPI, 1 I2C, RTC are configured.

aabadie · 2017-08-28T15:18:44Z

Updated this PR to work with all Adafruit Feather M0 boards: they are all built on the same base (same pinout) with different modules.

lebrush · 2017-08-31T09:58:55Z

I've too few experience with SAM processors to see if there's something weird... The only thing I could notice is that you'll have to run uncrustify on boards/feather-m0/include/periph_conf.h :-) .

One question: why can't the STDIO be accessed directly on the USB?

aabadie · 2017-08-31T11:36:40Z

why can't the STDIO be accessed directly on the USB?

Because there's no FDTI. The USB port is connected directly to the MCU, and that would required a software UART built on top of the USB. AFAIK, RIOT doesn't provide a USB stack (yet). Correct me if I'm wrong.

lebrush · 2017-08-31T12:52:42Z

The official page in the Adafruit website and states "This chip comes with built in USB so it has USB-to-Serial program & debug capability built in with no need for an FTDI-like chip" but I just checked how is this handled by the Arduino library and they implemented this part of the USB stack. So I guess that it's Ok like this :-)

aabadie · 2017-08-31T16:35:19Z

Not sure about the uncrustify issue but I pushed an update. Let me know if it's better for you now.

lebrush

They are just cosmetic thingys, sorry

lebrush · 2017-09-01T08:22:52Z

boards/feather-m0/include/periph_conf.h

+    {
+        .dev    = &SERCOM0->USART,
+        .rx_pin = GPIO_PIN(PA,11), /* RX pin */
+        .tx_pin = GPIO_PIN(PA,10), /* TX pin */


it' seems that uncrustify didn't get what I meant... sorry I thought it would: missing space between PA and number.

lebrush · 2017-09-01T08:23:17Z

boards/feather-m0/include/periph_conf.h

+    {TCC0, {
+        /* GPIO pin, MUX value, TCC channel */
+        { GPIO_UNDEF, (gpio_mux_t)0,  0 },
+        { GPIO_PIN(PA, 7), GPIO_MUX_E,  1 }, /* ~9 */


too many spaces before last parameter (also in pwm1)

lebrush · 2017-09-01T08:23:57Z

boards/feather-m0/include/periph_conf.h

+
+static const adc_conf_chan_t adc_channels[] = {
+    /* port, pin, muxpos */
+    {GPIO_PIN(PA, 2), ADC_INPUTCTRL_MUXPOS_PIN0},     /* A0 */


no spaces after and before curly braces

lebrush · 2017-09-01T08:24:25Z

boards/feather-m0/include/periph_conf.h

+ * @name    I2C configuration
+ * @{
+ */
+#define I2C_NUMOF          (1U)


space missing before (

aabadie · 2017-09-01T13:13:12Z

@lebrush, I addressed your comments

lebrush

Untested ACK

smlng · 2017-09-26T08:35:18Z

boards/feather-m0/include/board.h

+ *
+ * ### General information
+ *
+ * Feather M0 boards are development boards shipped by


nice detailed infos on that board, I'd rather put that into a separate doc.txt in the root directory of the board.

That's a good idea.
Maybe one day, it could be used to auto-generate (by replacing some keyword) the list for provided features (i2c, gpio, etc) for this board, when generating the doxygen documentation.

smlng · 2017-09-26T08:36:04Z

boards/feather-m0/include/board.h

+ */
+
+/**
+ * @defgroup    boards_adafruit-feather-m0 Adafruit Feather M0


should be boards_feather-m0 matching the path or rename the board directory

aabadie · 2017-09-27T07:40:48Z

I rebased this PR on #7646.

ynezz · 2017-09-28T12:10:50Z

boards/feather-m0/Makefile.include

+export CPU_MODEL = samd21g18a
+
+#export needed for flash rule
+export PORT_LINUX ?= /dev/ttyUSB0


@aabadie Mine is /dev/ttyACM0

@aabadie Maybe this two patches would fix this?

makefiles/tools/bossa: Introduce PORT_BOSSA variable
boards/feather-m0: Use PORT_BOSSA variable for flashing using Bossa

make -j10 BOARD=feather-m0 -C examples/hello-world flash term ... /opt/devel/mcu/RIOT/dist/tools/bossa/bossac -p /dev/ttyACM0 -e -i -w -v -b -R /opt/devel/mcu/RIOT/examples/hello-world/bin/feather-m0/hello-world.bin ... Done in 0.059 seconds CPU reset. ... /opt/devel/mcu/RIOT/dist/tools/pyterm/pyterm -p "/dev/ttyUSB0" -b "115200" 2017-09-28 15:21:58,683 - INFO # Connect to serial port /dev/ttyUSB0 Welcome to pyterm! Type '/exit' to exit. 2017-09-28 15:21:59,688 - INFO # main(): This is RIOT! (Version: 2017.10-devel-509-g52f9b-ntbk-feather-m0-testing)

Yes, I was thinking of something similar. Thanks, I'll update the PR asap

basilfx · 2017-11-05T19:34:46Z

boards/feather-m0/Makefile.features

@@ -0,0 +1,14 @@
+# Put defined MCU peripherals here (in alphabetical order)
+FEATURES_PROVIDED += periph_adc
+FEATURES_PROVIDED += periph_cpuid


Is now already in sam0_common/Makefile.features (see #7880)

basilfx · 2017-11-05T19:39:51Z

I have the Feather M0, and tested it. Works like a charm after I figured how to flash it.

Also tested the rebased version, and it works. #7880 should be applied though.

basilfx · 2017-11-05T20:37:07Z

boards/feather-m0/Makefile.features

+FEATURES_PROVIDED += periph_uart
+
+# The board MPU family (used for grouping by the CI system)
+FEATURES_MCU_GROUP = cortex_m0_2


Almost:

Last line should be: -include $(RIOTCPU)/samd21/Makefile.features (see other boards, e.g. arduino-zero).

Indeed, thanks for spotting this :)

basilfx · 2017-11-05T20:40:56Z

ACK when Murdock is green.

aabadie · 2017-11-05T20:48:46Z

The CI is broken because of a doxygen warning... I prepended a9f499c in order to fix this (it works locally on my machine)

basilfx · 2017-11-05T20:56:37Z

Wouldn't it be better to have a9f499c in a separate PR?

aabadie · 2017-11-05T21:14:04Z

Wouldn't it be better to have a9f499c in a separate PR?

Yes, that's also what I think. We'll have to wait a bit more before we can merge this one.

aabadie · 2017-11-05T21:18:46Z

Regarding the doxygen fix, I created #7939. Will remove the commit from this PR (and Murdock should fail)

basilfx · 2017-11-06T06:23:51Z

#7939 is merged, so this can be merged as soon as Murdock is green.

aabadie · 2017-11-06T08:40:15Z

@ynezz, now that this one is merged, you can propose a PR with your changes regarding the bootloader shell command.

aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Aug 24, 2017

aabadie added this to the Release 2017.10 milestone Aug 24, 2017

aabadie assigned astralien3000 Aug 24, 2017

aabadie force-pushed the adafruit_feather branch from b91dcc1 to 8fa7f78 Compare August 28, 2017 15:03

aabadie changed the title ~~boards/feather-m0-wifi: initial support (without atwinc1500)~~ boards/feather-m0: initial support Aug 28, 2017

aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 28, 2017

aabadie force-pushed the adafruit_feather branch 2 times, most recently from ae2ecf5 to 0ec2aec Compare August 28, 2017 15:38

lebrush reviewed Sep 1, 2017

View reviewed changes

aabadie force-pushed the adafruit_feather branch from 3e5d57d to 028a689 Compare September 1, 2017 10:14

lebrush approved these changes Sep 1, 2017

View reviewed changes

aabadie force-pushed the adafruit_feather branch from 028a689 to 41cd0f8 Compare September 1, 2017 17:52

This was referenced Sep 26, 2017

cpu/sam0-common: rename mkr ldscript to more a generic name #7646

Merged

Build arduino bootloader compatible application #7645

Closed

smlng reviewed Sep 26, 2017

View reviewed changes

aabadie force-pushed the adafruit_feather branch 3 times, most recently from 834307d to a9afb69 Compare September 27, 2017 07:40

aabadie added the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 27, 2017

ynezz reviewed Sep 28, 2017

View reviewed changes

aabadie force-pushed the adafruit_feather branch from a9afb69 to d7e50f7 Compare September 28, 2017 19:21

aabadie force-pushed the adafruit_feather branch from 2a8e7da to b81ec7c Compare October 12, 2017 20:33

aabadie removed the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 12, 2017

aabadie force-pushed the adafruit_feather branch from b81ec7c to 6fc84ad Compare October 12, 2017 20:33

aabadie added the Area: boards Area: Board ports label Oct 13, 2017

aabadie mentioned this pull request Oct 14, 2017

boards/sodaq-explorer: add configuration for rn2483 module #7733

Merged

aabadie mentioned this pull request Oct 27, 2017

readme: bump supported boards count #7885

Merged

basilfx requested changes Nov 5, 2017

View reviewed changes

aabadie force-pushed the adafruit_feather branch from 6fc84ad to cb110c4 Compare November 5, 2017 20:34

basilfx requested changes Nov 5, 2017

View reviewed changes

aabadie force-pushed the adafruit_feather branch from cb110c4 to 25aa6be Compare November 5, 2017 20:38

basilfx approved these changes Nov 5, 2017

View reviewed changes

aabadie force-pushed the adafruit_feather branch 2 times, most recently from 4e4d20c to 1fcb5d7 Compare November 5, 2017 20:47

aabadie mentioned this pull request Nov 5, 2017

doc: increase GRAPH_MAX_NODES to avoid doxygen warning #7939

Merged

aabadie added 2 commits November 5, 2017 22:19

boards/feather-m0: initial support

337e9d8

tests: exclude feather-m0 board from unittests

d011fd1

aabadie force-pushed the adafruit_feather branch from 8838575 to d011fd1 Compare November 5, 2017 21:19

miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 6, 2017

miri64 merged commit ce0a82f into RIOT-OS:master Nov 6, 2017

aabadie mentioned this pull request Sep 26, 2019

boards/arduino-mkr: feather-m0: sodaq-*: provide stdio over USB and setup automatic flash with bossa #12304

Merged

crasbe mentioned this pull request May 24, 2025

boards/feather-m0: Correct ADC Settings #21508

Merged

Conversation

aabadie commented Aug 24, 2017 • edited by miri64 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aabadie commented Aug 28, 2017

Uh oh!

lebrush commented Aug 31, 2017

Uh oh!

aabadie commented Aug 31, 2017

Uh oh!

lebrush commented Aug 31, 2017

Uh oh!

aabadie commented Aug 31, 2017

Uh oh!

lebrush left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie commented Sep 1, 2017

Uh oh!

lebrush left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie commented Sep 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

basilfx commented Nov 5, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

basilfx commented Nov 5, 2017

Uh oh!

aabadie commented Nov 5, 2017

Uh oh!

basilfx commented Nov 5, 2017

Uh oh!

aabadie commented Nov 5, 2017

Uh oh!

aabadie commented Nov 5, 2017

Uh oh!

basilfx commented Nov 6, 2017

Uh oh!

aabadie commented Nov 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aabadie commented Aug 24, 2017 •

edited by miri64

Loading