Skip to content

shell_commands: port ifconfig netstats neighbor for gnrc_netif2 #7463

Closed
bergzand wants to merge 29 commits intoRIOT-OS:masterfrom
bergzand:netstats/nb-netif2
Closed

shell_commands: port ifconfig netstats neighbor for gnrc_netif2 #7463
bergzand wants to merge 29 commits intoRIOT-OS:masterfrom
bergzand:netstats/nb-netif2

Conversation

@bergzand
Copy link
Copy Markdown
Member

@bergzand bergzand commented Aug 8, 2017

As requested in #7449.

Based on #7404 and #6873

Although the output should not have changed from #7449, I was unable to test the output for the command since I could not get a test with shell and netif2 working. Will try again and report tomorrow.

miri64 and others added 28 commits July 19, 2017 10:17
@miri64
gnrc_netif2: Introduction of a new GNRC network interface API
65962ab
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
8b7193f
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
ae0d004
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
a7dce24
@miri64
tests: add tests for gnrc_netif2
484628e
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
0ac7db2
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
7b7cfa7
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
be2c5a4
@miri64
fixup! tests: add tests for gnrc_netif2
380ae0e
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
709995f
@miri64
fixup! tests: add tests for gnrc_netif2
f21f9e0
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
b02d8a6
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
b527746
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
ffab9fa 
Restructure headers a bit
@miri64
fixup! tests: add tests for gnrc_netif2
0f86d5f 
Adapt tests for definition changes
@miri64
fixup! fixup! gnrc_netif2: Introduction of a new GNRC network interfa…
8ae9d23 
…ce API
@miri64
fixup! tests: add tests for gnrc_netif2
e8af293
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
f82633e 
Add missing include
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
0fb432a 
Move missing header to right file
@miri64
fixup! gnrc_netif2: Introduction of a new GNRC network interface API
14978d2 
Some fixes
@miri64
shell_commands: port ifconfig command for gnrc_netif2
80b8e5e
@miri64
auto_init: add netdev_tap gnrc_netif2 initialization for testing
40decbd
@bergzand
Add netopt for retrieving number of retransmissions
0c5b16f
@bergzand
drivers/mrf24j40 add tx_retries_needed netopt
0e6f0a8
@bergzand
Add support for link layer neigbor statistics
47bcf6e 
This patch adds support for per neighbor statistics such as
LQI/RSSI, tx count, failure count, rx count and ETX.
@bergzand
net/netstats: no not whipe non-existing entry
196a385
@bergzand
net/netstats Enable neighbor stats for ethernet drivers
e9ab031
@bergzand
shell/netif2: Add output for neighbor stats
2dcb3a9
@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 8, 2017

Thank you :-).

@miri64 miri64 self-requested a review August 8, 2017 22:07
@miri64 miri64 self-assigned this Aug 8, 2017
@miri64 miri64 added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. GNRC Area: network Area: Networking labels Aug 8, 2017
@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 8, 2017

Although the output should not have changed from #7449, I was unable to test the output for the command since I could not get a test with shell and netif2 working. Will try again and report tomorrow.

Take an example that has the ifconfig command and compile it with USEMODULE=gnrc_netif2 set in the environment. The counters will not increase, since the real integration into GNRC only starts at #7424, but at least the output should be testable.

@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented Aug 9, 2017

Tested and fixed, should be good now.

@smlng smlng added the State: waiting for other PR State: The PR requires another PR to be merged first label Aug 16, 2017
@miri64 miri64 mentioned this pull request Nov 15, 2017
Closed
@miri64
Copy link
Copy Markdown
Member

miri64 commented Dec 11, 2017

Needs rebase ;-).

@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented Dec 12, 2017

Do you mind if I pick this one up when the PR this is depending on has progressed a bit more?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Dec 12, 2017

Not at all. Just notify me, when you got back to this.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 27, 2018

Please rebase ;-)

@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 15, 2018

Ping @bergzand?

@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented Mar 16, 2018

@miri64 I might have ignored this a bit. Anyway, this PR is useless without #6873. I don't mind closing this one and maybe reopen it in the future if it happens to become useful then.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 17, 2018

Ok, then let's close this as memo for now so it is off my monthly radar ;-).

@miri64 miri64 closed this Mar 17, 2018
@miri64 miri64 added the State: archived State: The PR has been archived for possible future re-adaptation label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees

@miri64 miri64

Labels

Area: network Area: Networking Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: archived State: The PR has been archived for possible future re-adaptation State: waiting for other PR State: The PR requires another PR to be merged first

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bergzand @miri64 @smlng