drivers/mrf24j40 add tx retries needed get operation#7448
Merged
smlng merged 1 commit intoRIOT-OS:masterfrom Sep 28, 2017
Merged
drivers/mrf24j40 add tx retries needed get operation#7448smlng merged 1 commit intoRIOT-OS:masterfrom
smlng merged 1 commit intoRIOT-OS:masterfrom
Conversation
This was referenced Aug 6, 2017
Closed
bergzand
force-pushed
the
mrf24j40-tx-retries
branch
from
3c294ed to
ff5bb3b
Compare
Member
Author
|
Rebased because #7447 was merged. No longer depends on another PR. |
jnohlgard
added
Area: drivers
bergzand
force-pushed
the
mrf24j40-tx-retries
branch
from
ff5bb3b to
3699d5c
Compare
Member
Author
|
Rebased to resolve merge conflicts |
smlng
suggested changes
Sep 26, 2017
| /** | ||
| * @name Shift offsets for TXSTAT register (0x24) | ||
| * @{ | ||
| */ |
Member
There was a problem hiding this comment.
please put in parentheses and make explicitly unsigned, i.e (6U) - might not be necessary but would be more consistent with (majority) of RIOT code base.
| * @name Shift offsets for TXSTAT register (0x24) | ||
| * @{ | ||
| */ | ||
| #define MRF24J40_TXSTAT_MAX_FRAME_RETRIES_SHIFT 6 |
Member
Author
There was a problem hiding this comment.
Correct, I added it for completeness of that register definition
drivers/mrf24j40/mrf24j40_netdev.c
Outdated
| #ifdef MODULE_NETSTATS_L2 | ||
| if (netdev->event_callback && (dev->netdev.flags & MRF24J40_OPT_TELL_TX_END)) { | ||
| uint8_t txstat = mrf24j40_reg_read_short(dev, MRF24J40_REG_TXSTAT); | ||
| dev->tx_retries = (txstat >> MRF24J40_TXSTAT_MAX_FRAME_RETRIES_SHIFT); |
Member
There was a problem hiding this comment.
looks like a tab here? Change to spaces.
smlng
added
the
CI: ready for build
Member
Author
|
@smlng Thank you for you comments, I think I've addressed them all. |
Member
|
ACK, please squash |
bergzand
force-pushed
the
mrf24j40-tx-retries
branch
from
459ec7d to
a2d790c
Compare
Member
Author
|
squashed |
smlng
approved these changes
Sep 26, 2017
Member
|
Time to move this forward: ACK and GO! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires #7447