Skip to content

pkg: port nordic_softdevice_ble to gnrc_netif2#7419

Merged
kaspar030 merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_netif2/feat/nordic-ble-softdev
Nov 14, 2017
Merged

pkg: port nordic_softdevice_ble to gnrc_netif2#7419
kaspar030 merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_netif2/feat/nordic-ble-softdev

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Jul 26, 2017

Couldn't test this due to the soft device not being build properly (?)

Depends on #7370.

This PR is part of the network layer remodelling effort:
PR dependencies

@miri64 miri64 added GNRC Area: network Area: Networking Area: pkg Area: External package ports State: waiting for other PR State: The PR requires another PR to be merged first labels Jul 26, 2017
@miri64 miri64 requested a review from kaspar030 July 26, 2017 17:55
@miri64 miri64 force-pushed the gnrc_netif2/feat/nordic-ble-softdev branch from 053f76a to a584430 Compare July 30, 2017 18:43
@miri64 miri64 force-pushed the gnrc_netif2/feat/nordic-ble-softdev branch from a584430 to 3da0060 Compare August 21, 2017 10:58
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 21, 2017

Rebased to current master and current dependencies

@miri64 miri64 force-pushed the gnrc_netif2/feat/nordic-ble-softdev branch from 3da0060 to 88fb9e3 Compare October 10, 2017 09:53
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Oct 10, 2017
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 10, 2017

Rebased to current master, no longer waiting for other PR

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 10, 2017

@kaspar030 made some comments about my usage of LOG_ERROR() in #7410. I will remove them here and in the other PRs.

@miri64 miri64 changed the base branch from master to gnrc_netif2_integration/master October 27, 2017 15:28
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 27, 2017

I changed the base branch now to the freshly created gnrc_netif2_integration/master branch.

@kaspar030
Copy link
Copy Markdown
Contributor

Doesn't link, cannot test.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 13, 2017

Which application did you try?

@kaspar030
Copy link
Copy Markdown
Contributor

examples/default

@miri64 miri64 force-pushed the gnrc_netif2/feat/nordic-ble-softdev branch from 14ba8fa to 9d44608 Compare November 13, 2017 13:50
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 13, 2017

Rebased. Should work now.

@miri64 miri64 force-pushed the gnrc_netif2/feat/nordic-ble-softdev branch from 9d44608 to 5e0a517 Compare November 14, 2017 09:09
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 14, 2017

Another day a another rebase.

Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok. ACK. (Testing postponed until full netif2 branch is ready).

@kaspar030 kaspar030 merged commit 2154420 into RIOT-OS:gnrc_netif2_integration/master Nov 14, 2017
@miri64 miri64 deleted the gnrc_netif2/feat/nordic-ble-softdev branch November 14, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants