Merged
Conversation
miri64
added
GNRC
Area: network
miri64
force-pushed
the
gnrc_netif2/feat/nrfmin
branch
from
94a2d1d to
efd8843
Compare
miri64
force-pushed
the
gnrc_netif2/feat/nrfmin
branch
from
efd8843 to
5f987a3
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 21, 2017
Member
Author
|
Rebased to current master and current dependencies |
miri64
force-pushed
the
gnrc_netif2/feat/nrfmin
branch
from
5f987a3 to
4597193
Compare
miri64
added
CI: ready for build
Member
Author
|
Rebased to current master, no longer waiting for other PR |
haukepetersen
approved these changes
Oct 10, 2017
Contributor
haukepetersen
left a comment
haukepetersen
left a comment
There was a problem hiding this comment.
Changes look valid (though I must say I am looking forward to switching over solely to netif2 to get rid of all those ifdefs). Tested with gnrc_networking between nrf52dk and nrf52840dk, works as expected.
ACK
Member
Author
Me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports nrfmin for
gnrc_netif2.Depends on #7370.This PR is part of the network layer remodelling effort:
