board/arduino-leonardo: add initial support (without usb cdc) by tprrt · Pull Request #7306 · RIOT-OS/RIOT

tprrt · 2017-07-03T23:30:35Z

board/arduino-leonardo: add initial support (without usb cdc)

aabadie · 2017-07-04T05:07:29Z

Awesome!
briefly looking at the code, looks quite good already.
Thanks for providing this and welcome to RIOT !

miri64 · 2017-07-04T05:10:17Z

For reference: I've got the board, so when it's time to test I'm happy to do so.

miri64 · 2017-07-17T16:02:22Z

I get only

Connecting to programmer: .avrdude: butterfly_recv(): programmer is not responding

avrdude: butterfly_recv(): programmer is not responding
avrdude: butterfly_recv(): programmer is not responding
avrdude: butterfly_recv(): programmer is not responding
avrdude: butterfly_recv(): programmer is not responding
avrdude: butterfly_recv(): programmer is not responding
Found programmer: Id = ""; type = 
    Software Version = .; Hardware Version = �.
avrdude: butterfly_recv(): programmer is not responding
avrdude: butterfly_recv(): programmer is not responding
avrdude: error: buffered memory access not supported. Maybe it isn't
a butterfly/AVR109 but a AVR910 device?
avrdude: initialization failed, rc=-1
avrdude: AVR device initialized and ready to accept instructions
avrdude: Device signature = 0x88fb48
avrdude: Expected signature for ATmega32U4 is 1E 95 87
avrdude: butterfly_recv(): programmer is not responding
avrdude: error: programmer did not respond to command: leave prog mode
avrdude: butterfly_recv(): programmer is not responding
avrdude: error: programmer did not respond to command: exit bootloader

avrdude done.  Thank you.

/home/mlenders/Repositories/RIOT-OS/RIOT/examples/hello-world/../../Makefile.include:368: recipe for target 'flash' failed
make: *** [flash] Error 1
make: Leaving directory '/home/mlenders/Repositories/RIOT-OS/RIOT/examples/hello-world'

when trying to flash.

Could you maybe also update the udev-rules in dist/tools/vagrant/udev_rules for our vagrant users?

miri64 · 2017-11-15T18:11:10Z

Needs rebase, and please address my comment.

miri64 · 2017-11-28T20:07:05Z

Ping?

tprrt · 2017-12-12T08:08:38Z

@miri64 I have rebased this branch on master latest, in order to correct the conflicts, run static-tests and test on target.

tprrt · 2018-01-02T12:21:44Z

@aabadie, @miri64 : It is good for you so that this is merged in the next release ?

aabadie

It is good for you so that this is merged in the next release ?

After having a look at it, I think it it could make it. I have a few comments, see below.

boards/common/arduino-atmega/board.c

boards/common/arduino-atmega/include/board_common.h

cpu/atmega32u4/startup.c

cpu/atmega32u4/include/cpu_conf.h

cpu/atmega32u4/doc.txt

sys/pipe/pipe_dynamic.c

miri64 · 2018-12-18T14:32:15Z

Now tests/periph_timer and tests/periph_adc are compiling. However, the periph_timer application is failing:

2018-12-18 15:30:37,687 - INFO # main(): This is RIOT! (Version: 2018.10-RC1-436-gdd6ec-HEAD)
2018-12-18 15:30:37,688 - INFO # 
2018-12-18 15:30:37,716 - INFO # Test for peripheral TIMERs
2018-12-18 15:30:37,717 - INFO # 
2018-12-18 15:30:37,738 - INFO # Available timers: 1
2018-12-18 15:30:37,739 - INFO # 
2018-12-18 15:30:37,757 - INFO # Testing TIMER_0:
2018-12-18 15:30:37,802 - INFO # TIMER_0: ERROR on initialization - skipping
2018-12-18 15:30:37,803 - INFO # 
2018-12-18 15:30:37,805 - INFO # 
2018-12-18 15:30:37,817 - INFO # TEST FAILED

Are you sure the timer is configured correctly?

miri64 · 2018-12-18T14:32:50Z

Also, only squash if the reviewer asks you to. Otherwise it is hard to track your changes + I don't get notified when you force push ;-).

tprrt · 2018-12-20T21:48:22Z

@miri64 I only saw your comment about the squash, after having pushed my last fix. I'm taking note for next time.

miri64 · 2019-01-08T08:13:38Z

I'm not sure, when I next come to test this, but it might be that you need to adapt for #9130 if it is merged before :-/

kYc0o · 2019-01-08T09:48:01Z

@miri64 yes it will need some adaptation. However I think is limited to the removal of code duplication, should be straightforward.

miri64

Timer tests work now. @aabadie do we want to merge this before #9130 and refactor there?

miri64 · 2019-01-13T15:39:31Z

Ping @aabadie?

miri64 · 2019-01-13T15:45:34Z

In the meantime @tprrt: some apps require the arduino-leonardo in their BOARD_INSUFFICIENT_MEMORY list (see Murdock results). Please add.

PeterKietzmann · 2019-01-15T08:10:02Z

@tprrt the CI didn't pass (have a look at this output). On first sight it looks like some applications overflow this platforms memory.

miri64 · 2019-01-17T15:40:09Z

I rebased (required since upstream some additional tests were merged) and did that, but sadly I seem to be unable to push to tprrt:tprrt/leonardo :(. @tprrt could you allow me to push by setting this tick on the top right under the labels etc.

miri64 · 2019-02-08T23:10:47Z

Now that #9130 this needs another rebase and some refactoring :-/. @tprrt do you mind if I open a PR based on your changes to speed-up this process?

miri64 · 2019-02-08T23:19:22Z

😱 I did not intend to close this PR.... I somehow managed to push, but now I can't open it anymore oO

miri64 · 2019-02-08T23:24:41Z

Since the PR is now closed, I can't re-open the PR >.< (since I now can't push to your repo anymore)...

miri64 · 2019-02-08T23:25:27Z

So sorry >.<

miri64 · 2019-02-08T23:54:39Z

In the meantime: I stored what I actually wanted to push in https://github.com/miri64/RIOT/tree/leonardo-arduino/feat/initial.

keestux · 2019-02-09T13:35:08Z

Since the PR is now closed, I can't re-open the PR >.<...

Maybe @tprrt can reopen it. I remember to recently reopen my own closed PR.

maribu · 2019-02-26T18:07:42Z

In the meantime another round of refactoring of the AVR code took place, so that this PR would need to be rebased and adapted again.

@tprrt: Thank you for the effort you put in this PR. I am under the impression that other helping hand to get this PR merged could be beneficial. If you agree I could create a new PR based on this one and take over from here. (But this would need to wait until I finish my vacation, as I don't have access to the board right now.) (Obviously, the new PR would still pay credit to you via the @author tags and copyright headers.)

miri64 · 2019-03-07T09:51:25Z

@tprrt: Thank you for the effort you put in this PR. I am under the impression that other helping hand to get this PR merged could be beneficial. If you agree I could create a new PR based on this one and take over from here. (But this would need to wait until I finish my vacation, as I don't have access to the board right now.) (Obviously, the new PR would still pay credit to you via the @author tags and copyright headers.)

@maribu can you maybe do as proposed. You can find the original PR of this PR in the branch I mentioned in #7306 (comment):

In the meantime: I stored what I actually wanted to push in https://github.com/miri64/RIOT/tree/leonardo-arduino/feat/initial.

tprrt · 2019-03-21T09:38:29Z

@maribu No problem, you can do what you said.

tprrt changed the title ~~Tprrt/leonardo~~ board/arduino-leonardo: add initial support (without usb cdc) Jul 3, 2017

aabadie added Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jul 4, 2017

aabadie added this to the Release 2017.10 milestone Jul 4, 2017

miri64 mentioned this pull request Jul 4, 2017

ds1307: initial import of a driver for the DS1307 RTC #7312

Merged

miri64 requested a review from aabadie September 19, 2017 11:11

miri64 assigned aabadie and miri64 Sep 19, 2017

aabadie mentioned this pull request Oct 27, 2017

readme: bump supported boards count #7885

Merged

smlng added the Area: boards Area: Board ports label Oct 27, 2017

smlng modified the milestones: Release 2017.10, Release 2018.01 Nov 16, 2017

tprrt force-pushed the tprrt/leonardo branch 10 times, most recently from 169dd0b to 92601db Compare December 12, 2017 08:03

aabadie requested changes Jan 2, 2018

View reviewed changes

tprrt force-pushed the tprrt/leonardo branch 3 times, most recently from c8d8800 to 60e158a Compare December 20, 2018 21:47

miri64 mentioned this pull request Jan 8, 2019

atmega: refactor cpu/board code and build/flash variables #9130

Merged

miri64 approved these changes Jan 9, 2019

View reviewed changes

miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 13, 2019

aabadie approved these changes Jan 13, 2019

View reviewed changes

miri64 closed this Feb 8, 2019

miri64 force-pushed the tprrt/leonardo branch from 60e158a to 7226daf Compare February 8, 2019 23:17

miri64 mentioned this pull request Mar 7, 2019

boards/arduino-nano: Support for the Arduino Nano #9499

Merged

maribu mentioned this pull request Mar 21, 2019

boards: Add support for the Arduino-Leonardo #11227

Merged

tprrt deleted the tprrt/leonardo branch December 19, 2021 12:18

Conversation

tprrt commented Jul 3, 2017

Uh oh!

aabadie commented Jul 4, 2017

Uh oh!

miri64 commented Jul 4, 2017

Uh oh!

miri64 commented Jul 17, 2017

Uh oh!

miri64 commented Nov 15, 2017

Uh oh!

miri64 commented Nov 28, 2017

Uh oh!

tprrt commented Dec 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tprrt commented Jan 2, 2018

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miri64 commented Dec 18, 2018

Uh oh!

miri64 commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tprrt commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miri64 commented Jan 8, 2019

Uh oh!

kYc0o commented Jan 8, 2019

Uh oh!

miri64 left a comment

Choose a reason for hiding this comment

Uh oh!

miri64 commented Jan 13, 2019

Uh oh!

miri64 commented Jan 13, 2019

Uh oh!

PeterKietzmann commented Jan 15, 2019

Uh oh!

miri64 commented Jan 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miri64 commented Feb 8, 2019

Uh oh!

miri64 commented Feb 8, 2019

Uh oh!

miri64 commented Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miri64 commented Feb 8, 2019

Uh oh!

miri64 commented Feb 8, 2019

Uh oh!

keestux commented Feb 9, 2019 via email

Uh oh!

maribu commented Feb 26, 2019

Uh oh!

miri64 commented Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tprrt commented Mar 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

tprrt commented Dec 12, 2017 •

edited

Loading

miri64 commented Dec 18, 2018 •

edited

Loading

tprrt commented Dec 20, 2018 •

edited

Loading

miri64 commented Jan 17, 2019 •

edited

Loading

miri64 commented Feb 8, 2019 •

edited

Loading

miri64 commented Mar 7, 2019 •

edited

Loading