gnrc_ipv6_nib: provide component to handle ABRO#7270
Merged
cgundogan merged 2 commits intoRIOT-OS:masterfrom Oct 6, 2017
Merged
gnrc_ipv6_nib: provide component to handle ABRO#7270cgundogan merged 2 commits intoRIOT-OS:masterfrom
cgundogan merged 2 commits intoRIOT-OS:masterfrom
Conversation
miri64
added
GNRC
Area: network
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 29, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 30, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 30, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jul 4, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jul 5, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 11, 2017
3 tasks
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 17, 2017
miri64
force-pushed
the
gnrc_ipv6_nib/feat/abr-component
branch
from
d6d65ac to
dc6517e
Compare
Member
Author
|
Rebased to current master and current dependencies |
miri64
force-pushed
the
gnrc_ipv6_nib/feat/abr-component
branch
from
dc6517e to
b5a621c
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 21, 2017
miri64
force-pushed
the
gnrc_ipv6_nib/feat/abr-component
branch
from
b5a621c to
c4b3d7e
Compare
Member
Author
|
Rebased to current master |
miri64
added
CI: ready for build
cgundogan
requested changes
Oct 6, 2017
sys/include/net/gnrc/ipv6/nib/abr.h
Outdated
| extern "C" { | ||
| #endif | ||
|
|
||
| #if (GNRC_IPV6_NIB_CONF_6LBR && GNRC_IPV6_NIB_CONF_MULTIHOP_P6C) || defined(DOXYGEN) |
Member
There was a problem hiding this comment.
too many white spaces for my taste :P
Member
Author
There was a problem hiding this comment.
#if(GNRC_IPV6_NIB_CONF_6LBR&&GNRC_IPV6_NIB_CONF_MULTIHOP_P6C)||defined(DOXYGEN)
better?
| unsigned idx = nib_offl - _dsts; | ||
| if (idx < GNRC_IPV6_NIB_CONF_MULTIHOP_P6C) { | ||
| for (_nib_abr_entry_t *abr = _abrs; | ||
| abr < (_abrs + GNRC_IPV6_NIB_ABR_NUMOF); |
Member
There was a problem hiding this comment.
similar to _in_dsts() you could use _in_abrs() here.
| DEBUG("nib: Removing border router %s\n", ipv6_addr_to_str(addr_str, addr, | ||
| sizeof(addr_str))); | ||
| for (_nib_abr_entry_t *abr = _abrs; | ||
| abr < (_abrs + GNRC_IPV6_NIB_ABR_NUMOF); |
| } | ||
| } | ||
|
|
||
| void _nib_abr_add_pfx(_nib_abr_entry_t *abr, _nib_offl_entry_t *offl) |
| _nib_abr_entry_t *_nib_abr_iter(const _nib_abr_entry_t *last) | ||
| { | ||
| for (const _nib_abr_entry_t *abr = (last) ? (last + 1) : _abrs; | ||
| abr < (_abrs + GNRC_IPV6_NIB_ABR_NUMOF); |
| * @param[in] abr The border router. | ||
| * @param[in] offl The prefix to add. | ||
| */ | ||
| void _nib_abr_add_pfx(_nib_abr_entry_t *abr, _nib_offl_entry_t *offl); |
Member
There was a problem hiding this comment.
const for offl, maybe for abr also?
Member
Author
There was a problem hiding this comment.
abr is manipulated by this function, offl can do.
| * @return NULL, if @p last is the last prefix of @p abr or if @p last | ||
| * wasn't in NIB (and != NULL). | ||
| */ | ||
| _nib_offl_entry_t *_nib_abr_iter_pfx(_nib_abr_entry_t *abr, |
| #include "_nib-internal.h" | ||
|
|
||
| #if GNRC_IPV6_NIB_CONF_6LBR && GNRC_IPV6_NIB_CONF_MULTIHOP_P6C | ||
| int gnrc_ipv6_nib_abr_add(ipv6_addr_t *addr) |
miri64
force-pushed
the
gnrc_ipv6_nib/feat/abr-component
branch
from
c4b3d7e to
5d1dca9
Compare
Member
Author
|
First of all: rebased to current master, now addressing your comments |
Member
Author
|
Addressed comments and also added doc and tests for public functions ;-) |
miri64
force-pushed
the
gnrc_ipv6_nib/feat/abr-component
branch
from
fc619d4 to
9280658
Compare
Member
Author
|
Oops, forgot the |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 6, 2017
Member
|
@miri64 thanks for addressing my comments. It's safe to squash now! |
cgundogan
approved these changes
Oct 6, 2017
miri64
force-pushed
the
gnrc_ipv6_nib/feat/abr-component
branch
from
bab590f to
74a87a4
Compare
Member
Author
|
Squashed. |
miri64
force-pushed
the
gnrc_ipv6_nib/feat/abr-component
branch
from
74a87a4 to
361dc14
Compare
Member
Author
|
Fixed and squashed immediately errors reported by Murdock. |
Member
|
all lights are on green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a functionality to handle border router information for multihop prefix and 6LoWPAN context dissemination.
Depends on #7212.This PR is part of the network layer remodelling effort:
