Conversation
aabadie
added
Area: drivers
aabadie
added
the
State: WIP
|
I only have a LPS22HB (on a x-nucleo-iks01a2), not sure if it's the same. |
Maybe we can unify the driver (using pseudomodules and a generic implementation) |
|
They look quite different unfortunately... |
I'll see if I can fix this one but it won't be in the july release. Will close #4257. |
|
I don't have lps25h, so I can only review the code. If someone could provide me with a sensor I might try to debug the readout value issue. |
A-Paul
left a comment
A-Paul
left a comment
There was a problem hiding this comment.
Initially stumbled into a build error. See code comment.
| i2c_read_regs(LPS25H_BUS, LPS25H_ADDR, LPS25H_REG_PRESS_OUT_XL, &tmp[0], 3); | ||
| i2c_release(LPS25H_BUS); | ||
|
|
||
| val = (tmp[2] << 16) | (tmp[1] << 8) | tmp[0]; |
There was a problem hiding this comment.
On the atmega 8-bit platform this results in compile error from avr-gcc . The << 16 is illegal because it i equal or greater than the register size.
|
Thanks for raising up this one. I haven't tested it for a while. Will try to rework it in the coming weeks. |
|
Closing in favor of #10695 |
|
Closing was not needed here because it would have been closed automatically when #10695 is merged. |
|
Since when do we keep duplicates open on purpose? |
8 participants
This is an update of #4257 that proposed a driver for a temperature and pressure sensor.
I started the actual state there and added some cleanup and support for saul.
Tested with my ST MEMs module but it doesn't seem to work. Maybe @ReneHerthel or @vincent-d have an idea ?
(it returns 0 hPa and 42°C all time)