gnrc_ipv6_nib: add prefix list component#7222
Merged
cgundogan merged 3 commits intoRIOT-OS:masterfrom Oct 6, 2017
Merged
Conversation
miri64
added
GNRC
Area: network
miri64
added
State: waiting for other PR
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
from
0118125 to
f66942b
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 22, 2017
miri64
removed
the
State: WIP
Member
Author
|
Rebased to current #7212 and no longer WIP |
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
from
f66942b to
51f65b9
Compare
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
from
51f65b9 to
18b216d
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 27, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 27, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 29, 2017
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
from
945f669 to
dd13a6e
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 30, 2017
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
from
dd13a6e to
46a4282
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 30, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 30, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jul 4, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jul 5, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 11, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 11, 2017
3 tasks
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 17, 2017
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
from
cb1fe80 to
7842670
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 21, 2017
Member
Author
|
Rebased to current master and current dependencies |
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
from
7842670 to
7c19572
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 21, 2017
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
2 times, most recently
from
57a08f0 to
eb8a53c
Compare
Member
Author
|
Rebased to current master. |
miri64
added
CI: ready for build
cgundogan
requested changes
Oct 6, 2017
Member
cgundogan
left a comment
cgundogan
left a comment
There was a problem hiding this comment.
not much comments from my side here
sys/include/net/gnrc/ipv6/nib/pl.h
Outdated
| */ | ||
| typedef struct { | ||
| ipv6_addr_t pfx; /**< prefix */ | ||
| uint16_t pfx_len; /**< length of gnrc_ipv6_nib_pl_t::pfx in bits */ |
Member
Author
There was a problem hiding this comment.
For alignment reasons mainly, but can make it uint8_t (will result in the same size).
sys/include/net/gnrc/ipv6/nib/pl.h
Outdated
| * multicast address and its first @p pfx_len bits | ||
| * may not be 0. | ||
| * @param[in] pfx_len Length of @p pfx in bits. | ||
| * Condition 0 < @p pfx_len > 0 must hold. |
Member
There was a problem hiding this comment.
that's a very weird condition (:
Member
Author
There was a problem hiding this comment.
Its not weird... it's just a weird way to say pfx_len > 0... Anyway, will remove one of the ends ^^
| uint32_t now; | ||
| _nib_offl_entry_t *dst = _nib_offl_add(NULL, iface, pfx, pfx_len, _PL); | ||
|
|
||
| if (dst == NULL) { |
Member
Author
There was a problem hiding this comment.
Never said I'm strictly against them :P But for gnrc_ndp it was pointed out by @OlegHahm so I kept it in gnrc_ndp2 ;-).
| if (dst == NULL) { | ||
| return NULL; | ||
| } | ||
| assert((valid_ltime >= pref_ltime)); |
Member
There was a problem hiding this comment.
remove one level of parens, please
| pref_ltime += now; | ||
| } | ||
| if (valid_ltime != UINT32_MAX) { | ||
| if (((valid_ltime + now) == UINT32_MAX) && (now != 0)) { |
Member
There was a problem hiding this comment.
no need to check nor now != 0, because it cannot be 0 due to the check above (valid_ltime != UINT32_MAX).
Member
Author
|
Addressed @cgundogan's and @riot-ci's comments. |
cgundogan
approved these changes
Oct 6, 2017
Member
|
that was a quick one (: pleas squash! |
miri64
force-pushed
the
gnrc_ipv6_nib/feat/pl-component
branch
from
20e5e0e to
32746b4
Compare
Member
Author
|
Squashed |
Member
|
GO! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step in the grant NIB journey. Implements the prefix list view of the NIB (see NDP model). This is aiming to remove the ambiguity of assigned addresses to an interface and the prefix list, currently present in the NIB (and also adds the capability to forward based on the prefix list once implemented, see #4730).
Currently WIP. Still missing:Depends on #7212.This PR is part of the network layer remodelling effort:
