Skip to content

cpu/gpio: adapt GPIO implementations to #7173#7176

Merged
smlng merged 7 commits intoRIOT-OS:masterfrom
haukepetersen:opt_gpio_donotclearoninit
Oct 5, 2017
Merged

cpu/gpio: adapt GPIO implementations to #7173#7176
smlng merged 7 commits intoRIOT-OS:masterfrom
haukepetersen:opt_gpio_donotclearoninit

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Jun 12, 2017 •
edited
Loading

Adapted effected GPIO implementations according to the discussion in #7173.

Touched CPUs (to be tested):

  • stm32_common
  • stm32f1
  • samd21
  • saml21
  • msp430fxyz
  • kinetis_common
  • ezr32wg
  • cc26x0
  • cc2538

@haukepetersen haukepetersen added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jun 12, 2017
@haukepetersen haukepetersen added this to the Release 2017.07 milestone Jun 12, 2017
@haukepetersen haukepetersen mentioned this pull request Jun 12, 2017
Merged
@dylad
Copy link
Copy Markdown
Member

dylad commented Jun 14, 2017

@haukepetersen Tested on SAML21-XPRO, works perfectly.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jun 14, 2017

thanks!

@photonthunder
Copy link
Copy Markdown

photonthunder commented Jun 14, 2017

@haukepetersen works for the samd21

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jun 15, 2017

tested stm32f3discovery, slwstk6220a, and pba-d-01-kw2x

@aabadie aabadie changed the title cpu/gpio: adapt GPIO implenentations to #7173 cpu/gpio: adapt GPIO implementations to #7173 Jun 21, 2017
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 23, 2017

typo in msp430 commit message. Someone for testing on cc2538/cc2650 ? I can test next week no stm32f1 (even if I think this should be fine).

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 23, 2017
@haukepetersen haukepetersen force-pushed the opt_gpio_donotclearoninit branch from c9231f5 to abbc61f Compare June 28, 2017 07:09
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jun 28, 2017

fixed typo in commit message of msp430 fix

@haukepetersen haukepetersen force-pushed the opt_gpio_donotclearoninit branch from abbc61f to b31ee42 Compare July 13, 2017 10:30
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jul 13, 2017

rebased.

Does anyone have access to the still untested CPUs and is able to test this PR on those boards?

@haukepetersen haukepetersen force-pushed the opt_gpio_donotclearoninit branch from b31ee42 to 34abdc8 Compare August 24, 2017 15:20
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Aug 24, 2017

rebased and confirmed working on iotlab-m3 (stm32f1).

smlng
smlng reviewed Aug 24, 2017
View reviewed changes
cpu/ezr32wg/periph/gpio.c
GPIO_P_TypeDef *port = _port(pin);
uint32_t pin_pos = _pin_pos(pin);

if (mode == GPIO_IN_PD) {
Copy link
Copy Markdown
Member

@smlng smlng Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is that for, again?

Copy link
Copy Markdown
Contributor Author

@haukepetersen haukepetersen Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ezr32wg does not support pull-down resistors.

Copy link
Copy Markdown
Member

@smlng smlng Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thx for clarification!

@smlng
Copy link
Copy Markdown
Member

smlng commented Aug 24, 2017 •
edited
Loading

tested on remote-revb (cc2538), looks good

@smlng
Copy link
Copy Markdown
Member

smlng commented Aug 24, 2017

and works with TI sensor tag (cc26x0), that's all I got for testing here 😄

smlng
smlng approved these changes Aug 24, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Based on discussion and tests, does anybody have the missing board available?

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Aug 24, 2017

I do have a Z1 in the office somewhere, so I try to find it...

@haukepetersen haukepetersen force-pushed the opt_gpio_donotclearoninit branch 2 times, most recently from 0e4d8b7 to 70e17ee Compare October 4, 2017 10:14
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Oct 4, 2017

rebased. Also verified working for the z1.

@smlng: does your ACK still hold?

@smlng
Copy link
Copy Markdown
Member

smlng commented Oct 4, 2017

sure!

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Oct 4, 2017

normally Murdock should run after the reabase, shouldn't it?

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 5, 2017
@smlng
Copy link
Copy Markdown
Member

smlng commented Oct 5, 2017

all green, its tested, its good?! @haukepetersen, may I push the button?

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Oct 5, 2017

yes, you may!

@smlng smlng merged commit ccca27d into RIOT-OS:master Oct 5, 2017
@haukepetersen haukepetersen deleted the opt_gpio_donotclearoninit branch October 5, 2017 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaspar030 kaspar030

@smlng smlng

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2017.10

Development

Successfully merging this pull request may close these issues.

6 participants

@haukepetersen @dylad @photonthunder @aabadie @smlng @kaspar030