saul: add support for LEDs and buttons on pba-d-01-kw2x#7147
Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom Jun 13, 2017
Merged
saul: add support for LEDs and buttons on pba-d-01-kw2x#7147haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
Conversation
smlng
added
Area: drivers
This was referenced Jun 7, 2017
Member
Author
|
see #7152, too |
haukepetersen
requested changes
Jun 13, 2017
Contributor
haukepetersen
left a comment
haukepetersen
left a comment
There was a problem hiding this comment.
One minor comment, the rest looks good and works as expected -> ACK once addressed
| /** | ||
| * @brief GPIO pin configuration | ||
| */ | ||
| static const saul_gpio_params_t saul_gpio_params[] = |
Contributor
There was a problem hiding this comment.
seems like an additional space slipped in here...
| #endif | ||
|
|
||
| /** | ||
| * @brief GPIO pin configuration |
Member
Author
There was a problem hiding this comment.
mhm, this was actually intentional, to align the documentation
Contributor
There was a problem hiding this comment.
Yes, and it should, but it still makes sense to adhere to tabs (as in 4-space indentions). And this implies to leave 3 spaces behind the @brief, right?
Member
Author
There was a problem hiding this comment.
ah, you have the eagle eyes for spacing - haven't seen that 😉 addressed and squashed.
Member
Author
|
already squashed, 'cause minor change only |
haukepetersen
approved these changes
Jun 13, 2017
Contributor
|
All green -> go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add SAUL support for RGB LED, user button, and capacitive sensor button on board
pba-d-01-kw2x