Skip to content

boards/arduino-mkrfox1200: add initial implementation (without SigFox)#7092

Merged
kYc0o merged 2 commits intoRIOT-OS:masterfrom
aabadie:mkrfox1200
Jan 25, 2018
Merged

boards/arduino-mkrfox1200: add initial implementation (without SigFox)#7092
kYc0o merged 2 commits intoRIOT-OS:masterfrom
aabadie:mkrfox1200

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented May 23, 2017

This PR adds support for the mkrfox1200 board. It will be possible to use SigFox with it when #7087 is merged.

Since #6881 factorize the ports with mkr1000, this PR is based on it.

@aabadie aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first labels May 23, 2017
@aabadie aabadie added this to the Release 2017.07 milestone May 23, 2017
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Aug 29, 2017
@aabadie aabadie added the Area: boards Area: Board ports label Nov 4, 2017
@aabadie aabadie force-pushed the mkrfox1200 branch 2 times, most recently from 6cf76dc to 1989b19 Compare January 12, 2018 13:24
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jan 12, 2018

rebased and conflicts fixed

@aabadie aabadie force-pushed the mkrfox1200 branch 3 times, most recently from cd0c536 to 9a68b93 Compare January 21, 2018 17:19
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jan 22, 2018

This PR is ready for review, with #7087 (done in #7093), it can be used to send messages using Sigfox.

Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found minor issue.

+ *
+ * To access the STDIO of RIOT, a FTDI to USB converted needs to be plugged to
+ * the RX/TX pins on the board.
+ */ No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have a copy-paste issue here, all lines start by +.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, directly squashed and rebased

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Jan 25, 2018

ACK and go!

@kYc0o kYc0o merged commit be9a65a into RIOT-OS:master Jan 25, 2018
@aabadie aabadie deleted the mkrfox1200 branch June 8, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants