boards: add stm32f769 discovery#7051
Merged
aabadie merged 3 commits intoRIOT-OS:masterfrom May 17, 2017
Merged
Conversation
vincent-d
added
the
Platform: ARM
aabadie
requested changes
May 12, 2017
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
A few comments regarding doxygen and LED configuration. Otherwise the changes look good but I don't have this board for testing.
|
|
||
| /** | ||
| * @name LED pin definitions | ||
| * @{ |
Contributor
There was a problem hiding this comment.
The doxygen comments look weird in this file.
| #define LED2_MASK (1 << 12) | ||
| #define LED3_MASK (1 << 4) | ||
|
|
||
| #define LED0_ON (LED_PORT->BSRR = LED0_MASK) |
Contributor
There was a problem hiding this comment.
LED_PORT => LED0_PORT ?
same comment for LED1 and LED2
|
|
||
| #define LED3_ON (LED_PORT->BSRR = LED3_MASK) | ||
| #define LED3_OFF (LED_PORT->BSRR = (LED3_MASK << 16)) | ||
| #define LED3_TOGGLE (LED_PORT->ODR ^= LED3_MASK) |
Contributor
There was a problem hiding this comment.
If there are 4 LEDs why not adding the fourth one in board_init ?
Member
Author
|
Copy/paste are evil! @aabadie, comments addressed. |
aabadie
added
the
Type: new feature
aabadie
added
the
CI: ready for build
vincent-d
force-pushed
the
pr/stm32f7discovery
branch
from
6b9c048 to
1c637da
Compare
Member
Author
|
Fixed vendor header trailing white spaces and squashed. |
Member
|
Murdock issue most likely unrelated, see #7069. |
aabadie
added
CI: ready for build
Contributor
|
All green, go ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add basic support of stm32f769 discovery board and cpu (board manual here ). UART, LED and button works as expected, with SAUL support.
It also adds stm32f7 support in the RTC driver.