kernel_init: config_load, native: config_load: set id/address to PID by LudwigKnuepfer · Pull Request #700 · RIOT-OS/RIOT

LudwigKnuepfer · 2014-02-13T23:11:22Z

set nativenet address and id to the host process' PID on config_load
call config_load in kernel_init

Kijewski · 2014-02-13T23:15:16Z

boards/native/board_config.c

- * XXX: loading not implemented + * XXX: loading is implemented

Or just scrape the lines. :)

I'd rather leave it as the intention is to be able to load the whole configuration from file at some point.

kaspar030 · 2014-02-14T02:16:56Z

nice snipe. gratulations for hitting #700!

OlegHahm · 2014-02-15T17:57:04Z

Wouldn't it make more sense to always call config_load() when the config module is loaded (and not only with auto_init)?

OlegHahm · 2014-02-15T17:58:04Z

/home/oleg/git/RIOT/examples/default/bin/native/native_base.a(board_config.o): In function `config_load':
board_config.c:(.text+0xe): undefined reference to `DEBUG'

I guess a debug.h include is missing.

LudwigKnuepfer · 2014-02-21T15:37:15Z

@OlegHahm Always call config_load() - from where?

OlegHahm · 2014-02-21T15:49:24Z

Something like kernel_init()? I dunno.

addresses RIOT-OS#700 (comment)

also add include addresses RIOT-OS#700 (comment)

addresses RIOT-OS#700 (comment)

LudwigKnuepfer · 2014-02-24T16:46:22Z

rebased and issues addressed

OlegHahm · 2014-03-16T23:21:43Z

Since config_save isn't implemented I know get a weird address when using native with config module.

LudwigKnuepfer · 2014-03-17T10:12:00Z

If you mean PID with weird: that's half the idea of this PR.

OlegHahm · 2014-03-17T16:39:20Z

Maybe I shouldn't comment on stuff I haven't looked into for weeks after midnight and comment on them...

LudwigKnuepfer · 2014-03-17T16:41:19Z

You are still lacking sleep.

OlegHahm · 2014-03-17T17:19:19Z

Well, than ACK ~~and go~~.

Sorry, one more mistake: core changes, need a second ACK then.

LudwigKnuepfer · 2014-03-17T18:02:28Z

Needs squashing.

LudwigKnuepfer · 2014-03-18T07:14:15Z

rebased and sqashed

LudwigKnuepfer · 2014-03-19T13:44:10Z

@mehlis @Kijewski you want to ACK something? Try this ;-)

Kijewski · 2014-03-19T13:46:45Z

Quid pro quo? #859 has already one ACK.

Kijewski · 2014-03-19T13:47:59Z

cpu/native/include/nativenet_internal.h

~~Is this a write-only variable?~~

Kijewski · 2014-03-19T13:53:29Z

@OlegHahm Always call config_load() - from where?

Something like kernel_init()? I dunno.

Was this discussion finished?

LudwigKnuepfer · 2014-03-19T13:54:44Z

I migrated the call, yes.

Kijewski · 2014-03-19T14:00:20Z

Ah, now I see. I was confused by

 extern int main(void);
@@ -81,6 +88,11 @@ void kernel_init(void)

At first glance I though you used it in the project's main.

ACK.

kernel_init: config_load, native: config_load: set id/address to PID

LudwigKnuepfer added enhancement labels Feb 13, 2014

Kijewski reviewed Feb 13, 2014
View reviewed changes

OlegHahm self-assigned this Feb 14, 2014

LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Feb 24, 2014

move config_load from auto_init to kernel_init

11893e6

addresses RIOT-OS#700 (comment)

LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Feb 24, 2014

set id as well

b871ae3

also add include addresses RIOT-OS#700 (comment)

LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Feb 24, 2014

move config_load from auto_init to kernel_init

0b26d70

addresses RIOT-OS#700 (comment)

LudwigKnuepfer mentioned this pull request Mar 4, 2014

drivers/cpu: add function to get CPU id/serial number #854

Merged

Ludwig Ortmann added 2 commits March 18, 2014 08:07

native: config_load: set PID as id, net address

0501fe8

core: kernel_init: call config_load in kernel_init

e688efd

LudwigKnuepfer assigned haukepetersen and unassigned OlegHahm Mar 18, 2014

LudwigKnuepfer changed the title ~~nativenet config_load, auto_init~~ kernel_init: config_load, native: config_load: set id/address to PID Mar 18, 2014

LudwigKnuepfer assigned miri64 and unassigned haukepetersen Mar 18, 2014

Kijewski reviewed Mar 19, 2014
View reviewed changes

cpu/native/include/nativenet_internal.h

Copy link
Copy Markdown

Contributor

Kijewski Mar 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~Is this a write-only variable?~~

LudwigKnuepfer pushed a commit that referenced this pull request Mar 19, 2014

Merge pull request #700 from LudwigOrtmann/sniper_700

f490a70

kernel_init: config_load, native: config_load: set id/address to PID

LudwigKnuepfer merged commit f490a70 into RIOT-OS:master Mar 19, 2014

LudwigKnuepfer deleted the sniper_700 branch March 19, 2014 14:04

Conversation

LudwigKnuepfer commented Feb 13, 2014

Uh oh!

Kijewski Feb 13, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer Feb 13, 2014

Choose a reason for hiding this comment

Uh oh!

kaspar030 commented Feb 14, 2014

Uh oh!

OlegHahm commented Feb 15, 2014

Uh oh!

OlegHahm commented Feb 15, 2014

Uh oh!

LudwigKnuepfer commented Feb 21, 2014

Uh oh!

OlegHahm commented Feb 21, 2014

Uh oh!

LudwigKnuepfer commented Feb 24, 2014

Uh oh!

OlegHahm commented Mar 16, 2014

Uh oh!

LudwigKnuepfer commented Mar 17, 2014

Uh oh!

OlegHahm commented Mar 17, 2014

Uh oh!

LudwigKnuepfer commented Mar 17, 2014

Uh oh!

OlegHahm commented Mar 17, 2014

Uh oh!

LudwigKnuepfer commented Mar 17, 2014

Uh oh!

LudwigKnuepfer commented Mar 18, 2014

Uh oh!

LudwigKnuepfer commented Mar 19, 2014

Uh oh!

Kijewski commented Mar 19, 2014

Uh oh!

Kijewski Mar 19, 2014

Choose a reason for hiding this comment

Uh oh!

Kijewski commented Mar 19, 2014

Uh oh!

LudwigKnuepfer commented Mar 19, 2014

Uh oh!

Kijewski commented Mar 19, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants