Skip to content

kinetis: Unify default ISR definitions#6993

Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/kinetis-isr
May 30, 2017
Merged

kinetis: Unify default ISR definitions#6993
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/kinetis-isr

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

This moves the instantiation of the weak aliases for the dummy handler into a separate file that is shared between Kinetis CPUs in kinetis_common. A shared header vectors_kinetis.h is used to provide the declarations and documentation for all CPU specific ISRs. This makes it easier to keep the names of the ISR functions unified when the same hardware module is used in multiple CPUs.

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels May 2, 2017
@jnohlgard jnohlgard added this to the Release 2017.07 milestone May 2, 2017
@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 2, 2017
@haukepetersen
Copy link
Copy Markdown
Contributor

dosn't it make sense to move the vector tables all together into the kinetis_common tree and just put in some ifdefs for the differences?

@jnohlgard
Copy link
Copy Markdown
Member Author

What was the conclusion of the similar question on stm32? I think it would be easier to do it like this first, then we can try to merge stuff later on when we have the CPUs merged. There are a few open PRs from me for new CPU support which I would prefer to merge first before doing any major refactoring.

@haukepetersen
Copy link
Copy Markdown
Contributor

On the STM32 we never merged the vector files altogether, and never actually exported their headers somewhere...

Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works fine on the mulle. Maybe there is optimization potential for the future to move all vector defs to kinetis_common, but ACK for now.

@jnohlgard jnohlgard merged commit f6073c0 into RIOT-OS:master May 30, 2017
@jnohlgard jnohlgard deleted the pr/kinetis-isr branch May 30, 2017 06:48
@jnohlgard
Copy link
Copy Markdown
Member Author

murdock is green -> go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants