Skip to content

gnrc_ipv6_nib: add neighbor cache component#6988

Merged
cgundogan merged 3 commits intoRIOT-OS:masterfrom
miri64:gnrc_ipv6_nib/feat/nc-component
Oct 6, 2017
Merged

gnrc_ipv6_nib: add neighbor cache component#6988
cgundogan merged 3 commits intoRIOT-OS:masterfrom
miri64:gnrc_ipv6_nib/feat/nc-component

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented May 1, 2017 •
edited
Loading

Implements the neighbor cache component of the NIB (see NDP model), aimed to replace gnrc_ipv6_nc.

Depends on #6325 (merged) and #6767 (merged).

This PR is part of the network layer remodelling effort:
PR dependencies

@miri64 miri64 added GNRC Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT labels May 1, 2017
@miri64 miri64 requested a review from cgundogan May 1, 2017 18:46
@miri64 miri64 force-pushed the gnrc_ipv6_nib/feat/nc-component branch from 7080fa2 to 9148d06 Compare May 1, 2017 18:48
miri64 added a commit to miri64/RIOT that referenced this pull request May 1, 2017
@miri64
Merge RIOT-OS#6767 into RIOT-OS#6988
7b5f0ad
miri64 added a commit to miri64/RIOT that referenced this pull request May 1, 2017
@miri64
Merge RIOT-OS#6325 into RIOT-OS#6988
eb2806a
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first labels May 1, 2017
@miri64 miri64 force-pushed the gnrc_ipv6_nib/feat/nc-component branch from 5ba050a to 84535e5 Compare May 5, 2017 11:38
miri64 added a commit to miri64/RIOT that referenced this pull request May 5, 2017
@miri64
Merge branch 'evtimer/feat/initial' (RIOT-OS#6767) into RIOT-OS#6988
00c0e64
miri64 added a commit to miri64/RIOT that referenced this pull request May 5, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/internal' (RIOT-OS#6325) into (RIOT-…
de73e58 
…OS#6988)
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 5, 2017

Rebased to current master and depending PRs.

miri64 added a commit to miri64/RIOT that referenced this pull request May 5, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into HEAD
d8d7824
@miri64 miri64 mentioned this pull request May 5, 2017
Merged
2 tasks
@miri64 miri64 added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 5, 2017
miri64 added a commit to miri64/RIOT that referenced this pull request May 9, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into HEAD
cb9e9ae
miri64 added a commit to miri64/RIOT that referenced this pull request May 16, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into HEAD
ff8c972
miri64 added a commit to miri64/RIOT that referenced this pull request May 22, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into HEAD
af91921
@miri64 miri64 force-pushed the gnrc_ipv6_nib/feat/nc-component branch from 607e21f to b614563 Compare June 9, 2017 17:45
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 9, 2017
@miri64
Merge branch 'evtimer/feat/initial' (RIOT-OS#6767) into RIOT-OS#6988
2f5d010
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 9, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/internal' (RIOT-OS#6325) into RIOT-O…
b0d384a 
…S#6988
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 9, 2017

Rebased and adapted to changes in #6325. Since this was a little bit fiddly I also squashed

@miri64 miri64 force-pushed the gnrc_ipv6_nib/feat/nc-component branch from b614563 to 65ad5b5 Compare June 9, 2017 20:09
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 9, 2017
@miri64
Merge branch 'evtimer/feat/initial' (RIOT-OS#6767) into RIOT-OS#6988
37bcc22
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 9, 2017

Rebased to current master and #6767.

miri64
miri64 commented Jun 9, 2017
View reviewed changes
sys/net/gnrc/network_layer/ipv6/nib/nib_nc.c Outdated
memcpy(entry->l2addr, nib->l2addr, nib->l2addr_len);
entry->l2addr_len = nib->l2addr_len;
#endif
*state = nib;
Copy link
Copy Markdown
Member Author

@miri64 miri64 Jun 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can use _nib_nc_get(), I know. Will port ASAP.

Copy link
Copy Markdown
Member Author

@miri64 miri64 Jun 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jun 9, 2017
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 10, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into RI…
92027f4 
…OT-OS#7014
miri64
miri64 commented Jun 23, 2017
View reviewed changes
sys/net/gnrc/network_layer/ipv6/nib/_nib-internal.h Outdated
* @pre `(node != NULL) && (nce != NULL)`
*
* @param[in] node On-link entry.
* @param[out] nce External representation of the neighbor cache
Copy link
Copy Markdown
Member Author

@miri64 miri64 Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: representation representation

@aabadie aabadie modified the milestone: Release 2017.07 Jun 26, 2017
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 27, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into RI…
356604a 
…OT-OS#7014
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 30, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into R…
a779261 
…IOT-OS#7014
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 1, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into R…
75439d4 
…IOT-OS#7014
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 18, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into R…
6a87517 
…IOT-OS#7014
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/nc-component' (RIOT-OS#6988) into RI…
b457efa 
…OT-OS#7014
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Oct 6, 2017

Looks good since my last review. Please squash.

@miri64 miri64 force-pushed the gnrc_ipv6_nib/feat/nc-component branch from 976b835 to 40be23b Compare October 6, 2017 09:33
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 6, 2017

Squashed.

@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 6, 2017
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Oct 6, 2017

GO!

@cgundogan cgundogan merged commit 11baf13 into RIOT-OS:master Oct 6, 2017
@miri64 miri64 deleted the gnrc_ipv6_nib/feat/nc-component branch October 6, 2017 09:58
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 6, 2017

\o/

1 similar comment
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 6, 2017

\o/

@miri64 miri64 mentioned this pull request Oct 6, 2017
Merged
benpicco
benpicco reviewed Sep 3, 2020
View reviewed changes
sys/net/gnrc/network_layer/ipv6/nib/_nib-internal.c

DEBUG("nib: lookup ctx = %p, type = %u\n", (void *)ctx, type);
while (event != NULL) {
offset += event->event.offset;
Copy link
Copy Markdown
Contributor

@benpicco benpicco Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this adding up the offsets of all events up until the matching one?
What is this function doing?

Copy link
Copy Markdown
Member Author

@miri64 miri64 Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the offset of an event is referring to the event before, not the absolute offset.

benpicco
benpicco reviewed Sep 3, 2020
View reviewed changes
sys/net/gnrc/network_layer/ipv6/nib/_nib-internal.c
offset += event->event.offset;
if ((event->msg.type == type) &&
((ctx == NULL) || (event->msg.content.ptr == ctx))) {
return offset;
Copy link
Copy Markdown
Contributor

@benpicco benpicco Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my naive understanding I would expect

    return event->event.offset;

here

Copy link
Copy Markdown
Member Author

@miri64 miri64 Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would just give an arbritrary offset to the event of the event that fires before event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco left review comments

@kaspar030 kaspar030 kaspar030 left review comments

@cgundogan cgundogan cgundogan approved these changes

Assignees

@cgundogan cgundogan

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2017.10

Development

Successfully merging this pull request may close these issues.

5 participants

@miri64 @cgundogan @benpicco @kaspar030 @aabadie