boards/arduino-mkrzero: add initial support by aabadie · Pull Request #6881 · RIOT-OS/RIOT

aabadie · 2017-04-10T07:57:00Z

And factorize code with arduino-mkr1000 since these boards are very similar.
The Arduino MKRZERO uses the second SPI to connect a SD card device, I configured it to use the one available in RIOT. This is not yet tested though.

I also noticed that there's a third one in the family: Arduino MKRFOX1200 that offers a SigFox compatible antenna.

aabadie · 2017-04-10T07:57:29Z

And this PR is based on ~~#6666~~

aabadie · 2017-05-16T10:29:32Z

since #6666 has been merged, I rebased this one. Tested mkr1000, still works.

aabadie · 2017-05-16T15:05:10Z

boards/arduino-mkrzero/include/board.h

+ * @name    SD Card device configuration
+ * @{
+ */
+#define SDCARD_SPI_PARAM_SPI         (SPI_DEV(1))


This is the part, I'm not totally sure of. @haukepetersen or @vincent-d any comments?

Depends on what the question is... Does the arduino-mkrzero come with an on-board SD-card slot? If yes, then this looks valid to me (as long as the SD-card slot is connected to the pins mapped for SPI_DEV(1)...).

It should be ok, regarding the specs. I just don't know what CD1 is on the SD card reader.

Could be "card detect"?

Thanks, googling points toward this direction. I added a define for this pin below in the file.

haukepetersen · 2017-05-16T15:35:44Z

before merging this PR, I would however like to see a better solution for the bossa tool, as having the 4th board shipped with the same binary tool is ugly and bad -> so I would like to have a better solution before we go on. Sounds fair?

aabadie · 2017-05-16T16:02:16Z

Sounds fair?

Yes, I'm interested in looking into this except if you feel very motivated.

haukepetersen · 2017-05-17T10:06:34Z

done: #7068

kbumsik · 2017-05-19T16:01:37Z

boards/arduino-mkr-common/include/periph_conf_common.h

+        .clk_pin  = GPIO_PIN(PA, 13),
+        .miso_mux = GPIO_MUX_D,
+        .mosi_mux = GPIO_MUX_D,
+        .clk_mux  = GPIO_MUX_D,


I noticed my silly mistake while testing WINC1500 WiFi module. 🤕 Could you please change the MUX pads to:

.miso_mux = GPIO_MUX_C, .mosi_mux = GPIO_MUX_C, .clk_mux = GPIO_MUX_C,

Thank you.

no problem, directly squashed and pushed

aabadie · 2017-05-22T11:02:12Z

boards/arduino-mkr-common/include/periph_conf_common.h

+    },
+    {
+        .dev      = &SERCOM2->SPI,
+        .miso_pin = GPIO_PIN(PA, 15),


This pin definition for the second SPI is different from mkr1000. I'll have to provide the SPI configuration for each boards.

haukepetersen · 2017-05-23T07:36:10Z

now that #7068 is merged, would you mind to rebase and make use of it?

aabadie · 2017-05-23T07:53:26Z

would you mind to rebase and make use of it?

I'm on it

aabadie · 2017-07-17T10:12:48Z

@astralien3000, I pushed a fix regarding the PWM: pin ~2 and ~3 are working but I couldn't find the correct conf for pin ~4 and ~5. So there's only 2 available PWM pins in the default configuration.

Regarding the periph_timer test, I didn't test but it should work as I didn't change it and is working (normally) with mkr1000.

aabadie · 2017-08-21T12:18:34Z

@astralien3000, if you have some time can you give another try to this one ?

astralien3000 · 2017-08-21T14:54:34Z

periph_pwm OK (for ~2 and ~3)
periph_timer still blocking

aabadie · 2017-08-22T07:54:35Z

@astralien3000, thanks for testing again.

Regarding the timer test issue, I fixed it: by default mkrzero use the sdcard_spi module which itself uses xtimer and for some reason this messes up this test (TIMER_0 being initialized with different values apparently).
The fix is simply to remove the dependency to sdcard_spi which makes sense since this is up to the user to include it or not.

In the mean time, I also fixed the second spi periph configuration which was wrong.

Directly squashed and rebased.

Can you test again ?

astralien3000 · 2017-08-22T08:41:32Z

Yes ! Now it works !

aabadie · 2017-08-22T08:55:44Z

@haukepetersen, this one is ready now (and tested). Would be great if you could approve it (and merge ;)) !

aabadie · 2017-08-22T14:51:04Z

@haukepetersen ?

haukepetersen

Some minor things left, almost there :-)

haukepetersen · 2017-08-25T10:03:54Z

boards/arduino-mkr-common/include/arduino_pinmap.h

 #define ARDUINO_PIN_A5          GPIO_PIN(PA, 6)  /* AIN6 */
 #define ARDUINO_PIN_A6          GPIO_PIN(PA, 7)  /* AIN7 */
-/** @} */
+/** @ */


any reason for removing the }?

haukepetersen · 2017-08-25T10:04:09Z

boards/arduino-mkr-common/include/arduino_pinmap.h


 /**
- * @name    Mapping of MCU pins to Arduino pins
+ * @name   Mapping of MCU pins to Arduino pins


Indention off by one space.

haukepetersen · 2017-08-25T10:04:46Z

boards/arduino-mkr-common/include/board_common.h

+ */
+#define XTIMER              TIMER_0
+#define XTIMER_CHAN         (0)
+/** @} */


please remove this block - no need to re-define the default configuration

haukepetersen · 2017-08-25T10:06:46Z

boards/arduino-mkr1000/include/board.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2016 Inria
+ * Copyright (C) 2017 Inria


Actually, I think convention is to use 2016-2017 when editing. Applies to many files of this PR

aabadie · 2017-08-25T13:34:47Z

@haukepetersen, comments addressed.

haukepetersen

ACK

haukepetersen · 2017-08-25T20:41:09Z

all green -> go

aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 10, 2017

aabadie added this to the Release 2017.04 milestone Apr 10, 2017

aabadie assigned haukepetersen and kYc0o Apr 10, 2017

aabadie added the State: waiting for other PR State: The PR requires another PR to be merged first label Apr 10, 2017

aabadie force-pushed the mkrzero branch 3 times, most recently from 8411e1b to 3027ae1 Compare April 18, 2017 12:15

kaspar030 modified the milestones: Release 2017.04, Release 2017.07 Apr 21, 2017

aabadie force-pushed the mkrzero branch from 3027ae1 to 5341466 Compare May 16, 2017 10:18

aabadie removed the State: waiting for other PR State: The PR requires another PR to be merged first label May 16, 2017

aabadie force-pushed the mkrzero branch from 5341466 to 6fe3cd4 Compare May 16, 2017 12:22

aabadie commented May 16, 2017

View reviewed changes

kbumsik reviewed May 19, 2017

View reviewed changes

aabadie force-pushed the mkrzero branch 2 times, most recently from 32ab02a to 65dcbd4 Compare May 20, 2017 16:15

aabadie commented May 22, 2017

View reviewed changes

aabadie force-pushed the mkrzero branch 2 times, most recently from 5b3281a to b43879e Compare July 15, 2017 14:34

aabadie force-pushed the mkrzero branch from b43879e to 32b337f Compare July 17, 2017 10:07

aabadie force-pushed the mkrzero branch from 32b337f to 8741cc3 Compare August 19, 2017 20:04

aabadie force-pushed the mkrzero branch 2 times, most recently from fac316c to ad88779 Compare August 22, 2017 07:54

aabadie force-pushed the mkrzero branch from ad88779 to 14ca436 Compare August 22, 2017 08:47

aabadie force-pushed the mkrzero branch 2 times, most recently from 9e6168d to 4c35afe Compare August 22, 2017 14:47

haukepetersen requested changes Aug 25, 2017

View reviewed changes

aabadie added 4 commits August 25, 2017 15:18

cpu/sam0: unify for arduino-mkr1000 and arduino-mkrzero boards

b8070a6

boards/arduino-mkrzero: add initial support

cf10bbf

boards/arduino-mkr-common: factorize arduino-mkr boards to common place

333206a

boards/arduino-mkr1000: adapt implementation to use common code

b04bf93

aabadie force-pushed the mkrzero branch from 4c35afe to 5ae9634 Compare August 25, 2017 13:28

aabadie added 2 commits August 25, 2017 15:33

boards/arduino-mkrzero: adapt implementation to use common code

48bedff

tests/unittests: skip arduino-mkrzero

0163815

aabadie force-pushed the mkrzero branch from 5ae9634 to 0163815 Compare August 25, 2017 13:33

haukepetersen approved these changes Aug 25, 2017

View reviewed changes

haukepetersen merged commit 191f38b into RIOT-OS:master Aug 25, 2017

aabadie deleted the mkrzero branch February 26, 2018 10:33

Conversation

aabadie commented Apr 10, 2017

Uh oh!

aabadie commented Apr 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aabadie commented May 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented May 16, 2017

Uh oh!

aabadie commented May 16, 2017

Uh oh!

haukepetersen commented May 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented May 23, 2017

Uh oh!

aabadie commented May 23, 2017

Uh oh!

aabadie commented Jul 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aabadie commented Aug 21, 2017

Uh oh!

astralien3000 commented Aug 21, 2017

Uh oh!

aabadie commented Aug 22, 2017

Uh oh!

astralien3000 commented Aug 22, 2017

Uh oh!

aabadie commented Aug 22, 2017

Uh oh!

aabadie commented Aug 22, 2017

Uh oh!

haukepetersen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie commented Aug 25, 2017

Uh oh!

haukepetersen left a comment

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Aug 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aabadie commented Apr 10, 2017 •

edited

Loading

aabadie commented Jul 17, 2017 •

edited

Loading