[RFC] net/netstats L1/L2 per neighbor transfer statistics by bergzand · Pull Request #6873 · RIOT-OS/RIOT

bergzand · 2017-04-08T19:34:56Z

This WIP adds functionality for recording statistics split out per peer. The goal of these statistics are for RPL parent selection, for example based on the ETX of the connection to the potential parent.

A struct with these statistics is defined. At this moment an array of length 8 is added to the netdev struct. I went for this approach because ETX statistics can be radio dependent and if a device has multiple radios these statistics are clearly dependent on the radio. Statistics are updated on packets received from the neighbor or transmission to the neighbor.

Because the netdev callback used to process transmission result has no knowledge of the transmitted frame itself, I decided to implement a small ring buffer like construction to link transfers to the callback. This ring buffer assumes that the order of packets send to the radio and the callbacks are in the same order. The ring buffer consists of a array of netstats_peer_t pointers and 2 indexes for reading/writing positions. Multicast/broadcast transmissions are recorded as NULL ptr's preserving the order of this buffer.

RSSI and LQI values are kept as exponential weighted moving averages, this to have some average function over this data while keeping the stored data small. I prefer to store the RSSI values in dBm, but the current radio's return the raw values instead of dBm converted values.

I've added a netopt call to retrieve the statistics. I've used this to extend the ifconfig tool with these statistics.

This PR is a work in progress. It's probably not feasible to have this merged before the feature deadline.

I would like some feedback on the architecture build for this. If a different approach is preferred, I can rewrite this. Also, if a different algorithm for certain parts is preferred, I'd also like to hear

Todo:

ETX calculations
Implement byte counters
Some kind of freshness indication
RSSI in dBm, Needs a different PR to fix this in the radio drivers

bergzand · 2017-04-11T14:44:45Z

Added RFC tag :)

bergzand · 2017-06-15T15:04:53Z

Rebased and resolved merge conflict

bergzand · 2017-08-06T15:09:29Z

Rework of implementation, including a rename.

Now based on #7447 and #7448, works better with #6895.
ETX and freshness is implemented.

The byte and packet counters are under an extra pseudomodule because they are not necessary for application requiring ETX such as RPL MRHOF.

bergzand · 2017-08-07T10:01:36Z

No longer WIP.

bergzand · 2017-08-08T20:00:03Z

Prevents a segfault when no empty/stale entries are present and added support for ethernet devices.

Note that ETX doesn't really make sense with tap because there is no L2 ack mechanism, but it simplifies testing a lot.

miri64 · 2018-03-15T11:50:27Z

@bergzand I assume you are planning to port this to #8198 in the future?

bergzand · 2018-03-16T13:59:41Z

Yes, At some point I hope to build a v2 of this based on #8198

tcschmidt · 2018-05-30T23:04:03Z

@bergzand #8198 is merged, how to adapt right now?

bergzand · 2018-06-11T14:33:50Z

@tcschmidt As requested here #8198 contained only the initial headers and code required for the layered approach. As long as the netdev stack is not adapted to actually use the code, it is not possible to reworking this PR in a useful way.

benpicco · 2019-06-02T16:32:15Z

@bergzand is this still true?
What needs to be done before it's possible to add neighbor statistics into the stack and where should they go now?

miri64 · 2019-07-26T07:02:12Z

Ping @bergzand?

bergzand · 2019-07-26T08:05:54Z

@miri64 @benpicco Unfortunately I don't have time to work on this. I'm also not sure where this functionality should be hooked into the stack. Mostly as there are now multiple ideas floating around on how the link/phy layer should evolve.

chrysn · 2019-09-11T16:40:53Z

If this were resolved, would there be much work left to do to implement MRHOF? (The contiki users around me are kind of reluctant to switch that off).

bergzand · 2019-09-11T17:33:13Z

If this were resolved, would there be much work left to do to implement MRHOF? (The contiki users around me are kind of reluctant to switch that off).

Around 350 lines of code depending a bit on how much things changed in two years

stale · 2020-03-14T17:38:55Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

benpicco · 2020-04-15T11:45:34Z

netstats_nb shouldn't have a dependency on netdev.

This might actually be useful.
I think there is a case for allowing device-specific extra information per-neighbor.
E.g. with at86rf215 you might want to use different data rates for different nodes, depending on how good the link quality is.
You could also talk to MR-O-QPSK nodes and legacy O-QPSK nodes simultaneously if there was a way to store which node used which modulation.

miri64 · 2020-05-18T10:34:47Z

Would have thought the bot removes the stale label if you re-open the issue...

benpicco · 2020-05-29T12:07:53Z

@miri64 @benpicco Unfortunately I don't have time to work on this. I'm also not sure where this functionality should be hooked into the stack. Mostly as there are now multiple ideas floating around on how the link/phy layer should evolve.

I can take over. From what I gathered by talking to @miri64 was that it should not be part of GNRC (so not extending the NIB) but rather a separate L2 database - so pretty much what you did here.

benpicco · 2020-07-03T22:08:52Z

sys/net/netstats/netstats_neighbor.c

+/* find the oldest inactive entry to replace. Empty entries are infinity old */
+netstats_nb_t *netstats_nb_get_or_create(netdev_t *dev, const uint8_t *l2_addr, uint8_t len)


Wouldn't it be better to evict the entry with the worst signal?

benpicco · 2020-07-03T22:36:34Z

sys/include/net/netstats.h

+    uint32_t tx_count;      /**< Number of sent frames to this peer */
+    uint32_t tx_failed;     /**< Number of failed transmission tries to this peer */
+    uint32_t rx_count;      /**< Number of received frames */
+    uint32_t tx_bytes;      /**< Bytes sent */
+    uint32_t rx_bytes;      /**< Bytes received */


If those are just for printing out information, I'd rather drop them - 20 bytes / neighbor is quite a lot to keep around for curiosity's sake.

stale · 2021-01-06T12:17:41Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

miri64 · 2021-02-09T17:35:40Z

Very timely, stale bot, very timely ;-).

bergzand force-pushed the l2-peerstats branch 2 times, most recently from 652e815 to d6bd7e8 Compare April 8, 2017 19:38

miri64 assigned miri64 and OlegHahm Apr 9, 2017

bergzand changed the title ~~WIP: net/netstats L1/L2 per peer transfer statistics~~ [RFC] net/netstats L1/L2 per peer transfer statistics WIP Apr 11, 2017

miri64 added Area: network Area: Networking Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels May 30, 2017

bergzand force-pushed the l2-peerstats branch 2 times, most recently from 09559e4 to 5129d9d Compare June 15, 2017 15:04

aabadie modified the milestones: Release 2017.07, Release 2017.10 Jun 26, 2017

bergzand force-pushed the l2-peerstats branch from 5129d9d to 981869a Compare August 2, 2017 13:47

bergzand mentioned this pull request Aug 2, 2017

netdev: How to report transmit statistics #6888

Closed

bergzand force-pushed the l2-peerstats branch from 981869a to 9669278 Compare August 6, 2017 15:05

bergzand changed the title ~~[RFC] net/netstats L1/L2 per peer transfer statistics WIP~~ [RFC] net/netstats L1/L2 per neighbor transfer statistics WIP Aug 6, 2017

bergzand force-pushed the l2-peerstats branch from 9669278 to 2555384 Compare August 6, 2017 15:30

This was referenced Aug 6, 2017

sys/shell add neighbor stats output for ifconfig #7449

Closed

WIP: gnrc/rpl mrhof #7450

Closed

bergzand changed the title ~~[RFC] net/netstats L1/L2 per neighbor transfer statistics WIP~~ [RFC] net/netstats L1/L2 per neighbor transfer statistics Aug 7, 2017

miri64 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Aug 7, 2017

smlng removed this from the Release 2018.01 milestone Jan 15, 2018

stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 14, 2020

stale bot closed this Apr 14, 2020

miri64 reopened this Apr 15, 2020

benpicco mentioned this pull request May 10, 2020

RDM: The 802.15.4 Radio HAL #13943

Merged

stale bot closed this May 16, 2020

miri64 removed the State: stale State: The issue / PR has no activity for >185 days label May 18, 2020

miri64 reopened this May 18, 2020

benpicco self-requested a review June 12, 2020 20:12

miri64 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Jun 23, 2020

benpicco reviewed Jul 3, 2020

View reviewed changes

benpicco mentioned this pull request Jul 6, 2020

net/netstats: L1/L2 per neighbor statistics #14448

Merged

stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jan 6, 2021

stale bot closed this Feb 9, 2021

		/* find the oldest inactive entry to replace. Empty entries are infinity old */
		netstats_nb_t netstats_nb_get_or_create(netdev_t dev, const uint8_t *l2_addr, uint8_t len)

Conversation

bergzand commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bergzand commented Apr 11, 2017

Uh oh!

bergzand commented Jun 15, 2017

Uh oh!

bergzand commented Aug 6, 2017

Uh oh!

bergzand commented Aug 7, 2017

Uh oh!

bergzand commented Aug 8, 2017

Uh oh!

miri64 commented Mar 15, 2018

Uh oh!

bergzand commented Mar 16, 2018

Uh oh!

tcschmidt commented May 30, 2018

Uh oh!

bergzand commented Jun 11, 2018

Uh oh!

benpicco commented Jun 2, 2019

Uh oh!

miri64 commented Jul 26, 2019

Uh oh!

bergzand commented Jul 26, 2019

Uh oh!

chrysn commented Sep 11, 2019

Uh oh!

bergzand commented Sep 11, 2019

Uh oh!

stale bot commented Mar 14, 2020

Uh oh!

benpicco commented Apr 15, 2020

Uh oh!

miri64 commented May 18, 2020

Uh oh!

benpicco commented May 29, 2020

Uh oh!

benpicco Jul 3, 2020

Choose a reason for hiding this comment

Uh oh!

benpicco Jul 3, 2020

Choose a reason for hiding this comment

Uh oh!

stale bot commented Jan 6, 2021

Uh oh!

miri64 commented Feb 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

bergzand commented Apr 8, 2017 •

edited

Loading