boards/nucleos: deactivate LED0 auto init by default#6813
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Mar 30, 2017
Merged
boards/nucleos: deactivate LED0 auto init by default#6813aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie merged 1 commit intoRIOT-OS:masterfrom
Conversation
aabadie
added
Platform: ARM
Member
|
Shouldn't you also drop the saul registration of the LED ? |
Contributor
|
yapp, I would say so. |
Contributor
|
Also I think it would make sense to adapt the comment to quickly say why the LED is not initialized by default -> e.g. something like: |
aabadie
force-pushed
the
fix_nucleo_led_spi
branch
2 times, most recently
from
7bcb71d to
c3ecc01
Compare
Contributor
Author
|
@haukepetersen, @vincent-d, just pushed an update addressing your comments. Let me know if it's ok for you. |
aabadie
force-pushed
the
fix_nucleo_led_spi
branch
from
c3ecc01 to
8c33bd5
Compare
haukepetersen
added
the
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #6501
The problem doesn't exist with 32 and 144 pins versions of the nucleo boards.
I accept any better proposition for the macro name.