boards/nucleo: factorize code of the different board types (32 pins, 144 pins) by aabadie · Pull Request #6705 · RIOT-OS/RIOT

aabadie · 2017-03-06T23:26:47Z

This PR also adds/fixes Arduino support for nucleo-32 boards.

The serial configuration is shared between the different nucleo board types: 32, 64 and 144 pins.

We can even more factorize : move cpp feature to nucleo-common and share it with nucleo32 and nucleo144. The inheritance tree could also be improved with a common folder for all nucleo types, then a common for each board type (32, 64, 144), this is not what is done here but it can be changed if it makes more sense to the reviewers.

lebrush · 2017-03-07T08:08:23Z

boards/nucleo144-common/include/gpio_params.h

 /*
- * Copyright (C) 2017 Inria
- *               2017 OTA keys
+ * Copyright (C) Inria 2017


Copyright date switch

lebrush · 2017-03-07T08:11:14Z

boards/nucleo32-common/include/gpio_params.h

@@ -1,13 +1,13 @@
 /*
- * Copyright (C) 2017   Inria
+ * Copyright (C) Inria 2017


lebrush · 2017-03-07T08:17:40Z

I like this refactoring 👍 and codewise looks good.

Are you planning to include the 64 pin boards (there are many more of these more than of 32/144)?

aabadie · 2017-03-07T08:47:10Z

boards/nucleo144-f207/Makefile.include

-# load the common Makefile.include for Nucleo boards
-include $(RIOTBOARD)/nucleo-common/Makefile.include
+# include nucleo common serial configuration
+include $(RIOTBOARD)/nucleo-common/Makefile.include.serial


looking at my changes again, this line is not required as it's already include by indirectly by the line above. I'll update this for others.

aabadie · 2017-03-07T08:47:33Z

boards/nucleo144-f207/Makefile.include

+# include nucleo common serial configuration
+include $(RIOTBOARD)/nucleo-common/Makefile.include.serial
+
+# load the common Makefile.include for Nucleo-32 boards


nucleo-144 (auto-review ;) )

aabadie · 2017-03-07T08:49:39Z

@lebrush thanks for having a look.

Are you planning to include the 64 pin boards (there are many more of these more than of 32/144)?

In fact, the 64 pins are taken as reference as they are many more. So I think I'll keep it as it is in this PR.
I'll fix the copyright issue and a few other inconsistencies I just found.

aabadie · 2017-03-07T09:05:57Z

@lebrush I directly rebased and force push.

vincent-d · 2017-03-07T09:24:55Z

boards/nucleo144-common/include/gpio_params.h

+    {
+        .name = "B1(User button)",
+        .pin = BTN_B1_PIN,
+        .mode = GPIO_IN_PU


On nucleo144, the pin is pulled-down externally, so it should be either GPIO_IN or GPIO_IN_PD

Thanks ! I changed it to GPIO_IN_PD

aabadie · 2017-03-08T12:17:14Z

Looks like I broke a few things with gpio params, will fix.

aabadie · 2017-03-13T22:30:14Z

Rebased on master with #6714 inside. Related boards need to be tested (using saul in examples/default):

Nucleo 32
- nucleo32-l031
- nucleo32-f031
- nucleo32-f042
- nucleo32-f303
Nucleo 144
- nucleo144-f207
- nucleo144-f413

aabadie · 2017-03-14T16:53:03Z

Tested nucleo32-f042 and nucleo-f303 : works

vincent-d · 2017-03-15T16:15:57Z

I'll test the nucleo144-f207 and nucleo144-f413 by the end of the week if you don't have them.

aabadie · 2017-03-15T16:56:49Z

I have the 207 but not the 413, thanks

aabadie · 2017-03-15T17:19:06Z

nucleo144-f207 works

vincent-d · 2017-03-16T10:51:30Z

examples/default works on nucleo144-f413 (tested saul and rtc)

aabadie · 2017-03-16T15:48:21Z

Works also with nucleo32-f031 and nucleo32-l031. If someone (@vincent-d, @lebrush) could ACK that would be great.

vincent-d

ACK

vincent-d · 2017-03-16T16:06:08Z

And go!

aabadie · 2017-03-16T16:07:20Z

@vincent-d thanks ! but you forgot to wait for Murdock :)

vincent-d · 2017-03-16T16:17:50Z

@aabadie I saw only green on my screen...either a github lag, or my eyes. Sorry!

aabadie · 2017-03-16T16:21:36Z

np @vincent-d, it's just that Murdock is our "official" CI. Check that "Ready for CI build" label is set before pressing the green button ;)

aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Mar 6, 2017

aabadie added this to the Release 2017.04 milestone Mar 6, 2017

aabadie assigned haukepetersen and kYc0o Mar 6, 2017

aabadie changed the title ~~boards/nucleo: factorize code of the different board family (32 pins, 144 pins)~~ boards/nucleo: factorize code of the different board types (32 pins, 144 pins) Mar 6, 2017

lebrush reviewed Mar 7, 2017

View reviewed changes

aabadie commented Mar 7, 2017

View reviewed changes

aabadie force-pushed the nucleo32_common branch from ac25a6e to bd9a2c0 Compare March 7, 2017 09:05

vincent-d reviewed Mar 7, 2017

View reviewed changes

vincent-d mentioned this pull request Mar 7, 2017

cpu/stm32_common: unify gpio driver #6714

Merged

aabadie force-pushed the nucleo32_common branch 3 times, most recently from 8c1054d to 7b95c71 Compare March 13, 2017 22:21

aabadie force-pushed the nucleo32_common branch from 7b95c71 to 35962bd Compare March 13, 2017 22:46

aabadie mentioned this pull request Mar 15, 2017

boards/nucleo144-f446: add initial support #6553

Merged

aabadie added 4 commits March 16, 2017 10:50

boards/nucleo-common: extract serial configuration in extra Makefile

0b7ce88

boards/nucleo32-common: factorize common code for nucleo 32 boards

0ef7146

boards/nucleo32-f031: adapt to common nucleo32 code

dd4e0ea

boards/nucleo32-f042: adapt to common nucleo32 code

5f02a41

aabadie added 4 commits March 16, 2017 11:03

boards/nucleo32-f303: adapt to common nucleo32 code

607efec

boards/nucleo144-common: factorize common code for nucleo 144 boards

1c96a2d

boards/nucleo144-f207: adapt to common nucleo144 code

5634e0d

boards/nucleo144-f413: adapt to common nucleo144 code

62ccabc

aabadie force-pushed the nucleo32_common branch from 35962bd to 62ccabc Compare March 16, 2017 10:03

vincent-d approved these changes Mar 16, 2017

View reviewed changes

vincent-d merged commit 164d055 into RIOT-OS:master Mar 16, 2017

aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 16, 2017

aabadie deleted the nucleo32_common branch February 26, 2018 10:35

Conversation

aabadie commented Mar 6, 2017

Uh oh!

lebrush Mar 7, 2017

Choose a reason for hiding this comment

Uh oh!

lebrush Mar 7, 2017

Choose a reason for hiding this comment

Uh oh!

lebrush commented Mar 7, 2017

Uh oh!

aabadie Mar 7, 2017

Choose a reason for hiding this comment

Uh oh!

aabadie Mar 7, 2017

Choose a reason for hiding this comment

Uh oh!

aabadie commented Mar 7, 2017

Uh oh!

aabadie commented Mar 7, 2017

Uh oh!

vincent-d Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie Mar 7, 2017

Choose a reason for hiding this comment

Uh oh!

aabadie commented Mar 8, 2017

Uh oh!

aabadie commented Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aabadie commented Mar 14, 2017

Uh oh!

vincent-d commented Mar 15, 2017

Uh oh!

aabadie commented Mar 15, 2017

Uh oh!

aabadie commented Mar 15, 2017

Uh oh!

vincent-d commented Mar 16, 2017

Uh oh!

aabadie commented Mar 16, 2017

Uh oh!

vincent-d left a comment

Choose a reason for hiding this comment

Uh oh!

vincent-d commented Mar 16, 2017

Uh oh!

aabadie commented Mar 16, 2017

Uh oh!

vincent-d commented Mar 16, 2017

Uh oh!

aabadie commented Mar 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vincent-d Mar 7, 2017 •

edited

Loading

aabadie commented Mar 13, 2017 •

edited

Loading