Skip to content

xtimer: refine config macros#6702

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
smlng:xtimer/refine_macros
Oct 5, 2017
Merged

xtimer: refine config macros#6702
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
smlng:xtimer/refine_macros

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Mar 6, 2017

This PR refines some config macros for xtimer, i.e., XTIMER_SHIFT is auto set relative to XTIMER_HZ.

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: timers Area: timer subsystems labels Mar 6, 2017
@kYc0o kYc0o mentioned this pull request Mar 7, 2017
Closed
@smlng smlng added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Mar 7, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Mar 7, 2017 •
edited
Loading

waiting for #6507

actually its not required, so we may proceed with this one first?

@smlng smlng added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 7, 2017
@smlng smlng force-pushed the xtimer/refine_macros branch from 81d1d03 to 53e7729 Compare March 9, 2017 15:58
@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 19, 2017
@smlng smlng force-pushed the xtimer/refine_macros branch from 53e7729 to ab6fb22 Compare June 19, 2017 09:26
@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 19, 2017
kaspar030
kaspar030 requested changes Jun 19, 2017
View reviewed changes
sys/include/xtimer.h
*
* The direction of the shift is handled by the macros in tick_conversion.h
*/
#define XTIMER_SHIFT (0)
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 Jun 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make this case explicit, and err out if the shift values cannot be computed. Otherwise this breaks with e.g., 500kHz.

Copy link
Copy Markdown
Member Author

@smlng smlng Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, will adapt. Btw. 500kHz would be XTIMER_SHIFT (1) which is covered above, but not mentioned in the docu 😕

@smlng smlng added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 20, 2017
@smlng smlng added this to the Release 2017.07 milestone Jun 20, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jun 21, 2017

@kaspar030 may I squash? ... and you ACK 😉

@smlng smlng force-pushed the xtimer/refine_macros branch from e30374f to e2b6d00 Compare June 27, 2017 08:01
@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Jun 27, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jul 4, 2017

can we move on with this?

@smlng
xtimer: refine config macros
b012cdb 
    - auto set XTIMER_SHIFT relative to XTIMER_HZ
    - refine setting of XTIMER_WIDTH
@smlng smlng force-pushed the xtimer/refine_macros branch from e2b6d00 to b012cdb Compare September 20, 2017 14:49
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Sep 20, 2017

rebased

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Sep 28, 2017

ping @kaspar030

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Oct 5, 2017

@kaspar030 you have a blocking review here, anything to add, otherwise please approve.

@kaspar030 kaspar030 merged commit 4a5b9b5 into RIOT-OS:master Oct 5, 2017
@smlng smlng deleted the xtimer/refine_macros branch October 5, 2017 11:44
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Oct 5, 2017

So we forgot #6507 ? 🙄

@kaspar030 kaspar030 mentioned this pull request Oct 6, 2017
Merged
@smlng smlng mentioned this pull request Oct 7, 2017
Closed
@jnohlgard jnohlgard mentioned this pull request Oct 10, 2017
Merged
@smlng smlng mentioned this pull request Oct 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

@kaspar030 kaspar030

Labels

Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2017.10

Development

Successfully merging this pull request may close these issues.

4 participants

@smlng @kYc0o @kaspar030 @aabadie